Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64) #8578

Closed
wants to merge 8 commits into from

Conversation

dchigarev
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

@github-actions github-actions bot added the needs-rebase A PR that needs to be rebased by the author label Nov 30, 2020
@dchigarev dchigarev changed the title ARROW-10479: [C++] Get rid of code duplication at decimal type builders ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64) Dec 28, 2020
@dchigarev dchigarev force-pushed the decimal_dupl branch 7 times, most recently from 021e641 to 1d16309 Compare January 20, 2021 16:55
@pitrou
Copy link
Member

pitrou commented Jan 26, 2021

@dchigarev What is the status of this PR? Do you intend to finish working on it?

@dchigarev
Copy link
Author

dchigarev commented Jan 26, 2021

@pitrou generally PR is ready, now I'm fixing CI failures caused by my incorrectly usage of ARROW_EXPORT attribute, I hope I'll have an opportunity to mark it as ready for review at the next week

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev force-pushed the decimal_dupl branch 3 times, most recently from f970a89 to 09f7b1c Compare February 8, 2021 09:57
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@pitrou
Copy link
Member

pitrou commented Jul 27, 2021

@dchigarev This PR is still in draft. Are you planning to update and/or submit it?
(also, it would need rebasing on current master)

@baumgold
Copy link
Member

Hi. Any update here? Thanks.

@dchigarev
Copy link
Author

The PR is pretty much outdated and would take a lot of effort to align it with the master I think. So it's better to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: C++ Component: R needs-rebase A PR that needs to be rebased by the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants