Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer][Archery] Expose execution time in benchmark results #27445

Closed
asfimport opened this issue Feb 9, 2021 · 1 comment
Closed

[Developer][Archery] Expose execution time in benchmark results #27445

asfimport opened this issue Feb 9, 2021 · 1 comment

Comments

@asfimport
Copy link
Collaborator

Google Benchmark reports both cpu time & real time in each benchmark observation. For example:

{'cpu_time': 9718937.499999996,
  'items_per_second': 26972495.707478322,
  'iterations': 64,
  'name': 'TakeStringRandomIndicesWithNulls/262144/0',
  'null_percent': 0.0,
  'real_time': 10297947.859726265,
  'repetition_index': 2,
  'repetitions': 0,
  'run_name': 'TakeStringRandomIndicesWithNulls/262144/0',
  'run_type': 'iteration',
  'size': 262144.0,
  'threads': 1,
  'time_unit': 'ns'},

Currently, Archery doesn't expose the execution time in its json results though. For example:

                {
                    "name": "TakeStringRandomIndicesWithNulls/262144/2",
                    "unit": "items_per_second",
                    "less_is_better": false,
                    "values": [
                        20900887.666890558,
                        21737551.30809738,
                        21872425.314689018
                    ]
                }

This pull request updates Archery to expose the real time as well. For example:

                {
                    "name": "TakeStringRandomIndicesWithNulls/262144/2",
                    "unit": "items_per_second",
                    "less_is_better": false,
                    "values": [
                        20900887.666890558,
                        21737551.30809738,
                        21872425.314689018
                    ],
                    "time_unit": "ns",
                    "times": [
                        34939132.454438195,
                        44459594.18080747,
                        46606865.63566384
                    ]
                }

Motivation: I am persisting these results and would also like to store the execution time to debug slow benchmarks.

Reporter: Diana Clarke / @dianaclarke
Assignee: Diana Clarke / @dianaclarke

PRs and other links:

Note: This issue was originally created as ARROW-11575. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Ben Kietzman / @bkietz:
Issue resolved by pull request 9458
#9458

@asfimport asfimport added this to the 4.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant