Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] CSV reader should validate options #28712

Closed
asfimport opened this issue Jun 7, 2021 · 2 comments
Closed

[C++] CSV reader should validate options #28712

asfimport opened this issue Jun 7, 2021 · 2 comments
Labels
Component: C++ Type: bug
Milestone
5.0.0

Comments

@asfimport
Copy link
Collaborator

Currently the only validation of csv options is done by asserts. These options should always be validated by the reader on each reader creation.

Reporter: Nate Clark / @n3world
Assignee: Nate Clark / @n3world

PRs and other links:

Note: This issue was originally created as ARROW-12995. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Nate Clark / @n3world:
One of the validations I tried to add was that ReadOptions::block_size needs to be at least 1KB which seemed like a reasonable minimum but there are some csv tests which set block size to really small. I can update those tests to work with a larger block size or I can change the minimum block size to something like 1, any preferences?

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 10505
#10505

@asfimport asfimport added this to the 5.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Type: bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@asfimport