[C++] Add fixed_size_binary support to compute functions

[asfimport]

The following compute functions do not support fixed_size_binary but do support binary:

• binary_length
• binary_replace_slice
• count_substring
• find_substring
• find_substring_regex
• equal
• greater
• greater_equal
• less
• less_equal

Reporter: Weston Pace / @westonpace
Assignee: David Li / @lidavidm

Related issues:

• [C++][Compute] Add fixed_size_binary support to more compute functions (is related to)
• [C++] Mixed support for binary types in regex functions (is related to)

PRs and other links:

• GitHub Pull Request #11230

_{Note: This issue was originally created as ARROW-13878. Please see the migration documentation for further details.}

[asfimport]

Eduardo Ponce / @edponce:
Can we break these into individual issues (if not already)?

[asfimport]

Eduardo Ponce / @edponce:
FixedSizeBinaryType serves as the base class for DecimalTypes, then this would allow casting decimals to binary and applying string transforms. Is there any use case where it is used to represent strings for which the substring kernels make sense? Well, maybe there is an application that uses fixed size strings for some data. Based on this, then all the other string kernels in ARROW-13879 also need to be updated to support FixedSizeBinaryTypes.

[asfimport]

Eduardo Ponce / @edponce:
I would have made the distinction that kernels that are named with string or unambiguously operate on strings should only support string types. Nevertheless, in the software community the terms binary strings are common, so it would be difficult to provide a consistent nomenclature.

[asfimport]

Eduardo Ponce / @edponce:
Also, should string kernels prefixed with ascii or utf8 need to support binary types as well? or at least the ASCII ones?

[asfimport]

David Li / @lidavidm:
Decimal is not relevant here. ascii/utf8 should never support binary, they may rely on invariants which do not hold - cast first.

[asfimport]

Eduardo Ponce / @edponce:
@lidavidm Thanks for the clarifications.

[asfimport]

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11230
#11230