Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] Add explicit output values to sign function and fix unary type checks #29547

Closed
asfimport opened this issue Sep 8, 2021 · 1 comment

Comments

@asfimport
Copy link
Collaborator

asfimport commented Sep 8, 2021

The sign function implementation for unsigned integers returns the result of a boolean expression because when casted to an integer it corresponds to the expected value (0 or 1). To make the function more clear, we should be explicit with the return values similar to the other sign kernels.

Reporter: Eduardo Ponce / @edponce
Assignee: Eduardo Ponce / @edponce

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-13937. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Issue resolved by pull request 11113
#11113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant