Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Function not declared in scope #30338

Closed
asfimport opened this issue Nov 23, 2021 · 1 comment
Closed

[R] Function not declared in scope #30338

asfimport opened this issue Nov 23, 2021 · 1 comment
Assignees
Milestone

Comments

@asfimport
Copy link
Collaborator

Starting with ARROW-13111, CI for R versions 3.4 and 3.3 have been failing with:

In file included from ./arrow_types.h:22:0,
                 from altrep.cpp:18:
././arrow_cpp11.h: In lambda function:
././arrow_cpp11.h:108:23: error: ‘STRING_PTR_ROwas not declared in this scope
     const SEXP* p_x = STRING_PTR_RO(x);
                       ^~~~~~~~~~~~~
././arrow_cpp11.h:108:23: note: suggested alternative: ‘STRING_PTRconst SEXP* p_x = STRING_PTR_RO(x);
                       ^~~~~~~~~~~~~
                       STRING_PTR
altrep.cpp: In functionstd::shared_ptr<arrow::Array> arrow::r::altrep::vec_to_arrow_altrep_bypass(SEXP)’:
altrep.cpp:709:24: error: ambiguating new declaration ofstd::shared_ptr<arrow::Array> arrow::r::altrep::vec_to_arrow_altrep_bypass(SEXP)’
 std::shared_ptr<Array> vec_to_arrow_altrep_bypass(SEXP x) { return nullptr; }
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from altrep.cpp:18:0:
./arrow_types.h:190:31: note: old declarationstd::shared_ptr<arrow::ChunkedArray> arrow::r::altrep::vec_to_arrow_altrep_bypass(SEXP)’
 std::shared_ptr<ChunkedArray> vec_to_arrow_altrep_bypass(SEXP);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~
g++ -std=gnu++11 -I/opt/R/3.4.4/lib/R/include -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-6.0.1.9000/include  -DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_S3 -DARROW_R_WITH_JSON -I../inst/include/  -I/usr/local/include   -fpic  -g -O2 -c array.cpp -o array.o
In file included from ./arrow_types.h:22:0,
                 from array.cpp:18:
././arrow_cpp11.h: In lambda function:
././arrow_cpp11.h:108:23: error: ‘STRING_PTR_ROwas not declared in this scope
     const SEXP* p_x = STRING_PTR_RO(x);
                       ^~~~~~~~~~~~~
/opt/R/3.4.4/lib/R/etc/Makeconf:168: recipe for target 'altrep.o' failed
make: *** [altrep.o] Error 1
make: *** Waiting for unfinished jobs....
././arrow_cpp11.h:108:23: note: suggested alternative: ‘STRING_PTRconst SEXP* p_x = STRING_PTR_RO(x);
                       ^~~~~~~~~~~~~
                       STRING_PTR
/opt/R/3.4.4/lib/R/etc/Makeconf:168: recipe for target 'array.o' failed
make: *** [array.o] Error 1
ERROR: compilation failed for packagearrow’
* removing ‘/arrow/r/check/arrow.Rcheck/arrow

https://github.com/ursacomputing/crossbow/runs/4295709576?check_suite_focus=true#step:8:1402

It looks like we need a bit more gating here to only use this code when altrep is available in R

Reporter: Jonathan Keane / @jonkeane
Assignee: Jonathan Keane / @jonkeane

PRs and other links:

Note: This issue was originally created as ARROW-14803. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Nicola Crane / @thisisnic:
Issue resolved by pull request 11772
#11772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants