ARROW-14803: [R] Function not declared in scope #11772
Conversation
|
@github-actions crossbow submit test-r-versions: |
|
@github-actions crossbow submit test-r-versions |
|
Revision: dfb6016 Submitted crossbow builds: ursacomputing/crossbow @ actions-1173
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: 0b08b65 Submitted crossbow builds: ursacomputing/crossbow @ actions-1175
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: a551447 Submitted crossbow builds: ursacomputing/crossbow @ actions-1178
|
| @@ -706,7 +706,7 @@ SEXP MakeAltrepVector(const std::shared_ptr<ChunkedArray>& chunked_array) { | |||
|
|
|||
| bool is_arrow_altrep(SEXP) { return false; } | |||
|
|
|||
| std::shared_ptr<Array> vec_to_arrow_altrep_bypass(SEXP x) { return nullptr; } | |||
| std::shared_ptr<ChunkedArray> vec_to_arrow_altrep_bypass(SEXP x) { return nullptr; } | |||
There was a problem hiding this comment.
Looks odd that this goes from Array to ChunkedArray in this PR.
|
Benchmark runs are scheduled for baseline = 8581f36 and contender = 236362a. 236362a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
It looks like there was an order-of-imports issue and then one place where a return type wasn't quite right (when altrep wasn't defined). These changes make the old versions pass again (though there might be a better way to accomplish this!) Closes apache#11772 from jonkeane/r-versions-fix Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
It looks like there was an order-of-imports issue and then one place where a return type wasn't quite right (when altrep wasn't defined). These changes make the old versions pass again (though there might be a better way to accomplish this!)