You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using OT we should add spans that report the runtime of kernel functions. We should ensure that, if OT is disabled, there is no significant overhead.
In addition we should add spans that report the runtime of each exec node. This may be a little trickier than it would first seem because pipeline breakers like join, etc. don't do all of their work inside of InputReceived. Those could potentially be added later in follow-up PRs if it is getting to be too tricky. The simple nodes like FilterNode and ProjectNode should be more straightforward. These spans should be the parent of any kernel functions launched by that node.
There should also be a span for an entire exec plan run that will be the parent of all of this.
David Li / @lidavidm: PR#11906 does this for kernel functions, but not for nodes, as a starter/something to build off of. It also doesn't add a span for the entire exec plan (that may be more annoying to #ifdef guard properly).
Using OT we should add spans that report the runtime of kernel functions. We should ensure that, if OT is disabled, there is no significant overhead.
In addition we should add spans that report the runtime of each exec node. This may be a little trickier than it would first seem because pipeline breakers like join, etc. don't do all of their work inside of InputReceived. Those could potentially be added later in follow-up PRs if it is getting to be too tricky. The simple nodes like FilterNode and ProjectNode should be more straightforward. These spans should be the parent of any kernel functions launched by that node.
There should also be a span for an entire exec plan run that will be the parent of all of this.
Reporter: Weston Pace / @westonpace
Assignee: Matthijs Brobbel / @mbrobbel
Related issues:
PRs and other links:
Note: This issue was originally created as ARROW-15061. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: