Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add logging for kernel functions and exec plan nodes #30576

Closed
Tracked by #30574
asfimport opened this issue Dec 10, 2021 · 2 comments
Closed
Tracked by #30574

[C++] Add logging for kernel functions and exec plan nodes #30576

asfimport opened this issue Dec 10, 2021 · 2 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Dec 10, 2021

Using OT we should add spans that report the runtime of kernel functions. We should ensure that, if OT is disabled, there is no significant overhead.

In addition we should add spans that report the runtime of each exec node. This may be a little trickier than it would first seem because pipeline breakers like join, etc. don't do all of their work inside of InputReceived. Those could potentially be added later in follow-up PRs if it is getting to be too tricky. The simple nodes like FilterNode and ProjectNode should be more straightforward. These spans should be the parent of any kernel functions launched by that node.

There should also be a span for an entire exec plan run that will be the parent of all of this.

Reporter: Weston Pace / @westonpace
Assignee: Matthijs Brobbel / @mbrobbel

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-15061. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
PR#11906 does this for kernel functions, but not for nodes, as a starter/something to build off of. It also doesn't add a span for the entire exec plan (that may be more annoying to #ifdef guard properly).

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Issue resolved by pull request 12100
#12100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant