Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Expose RecordBatchReader::MakeFromIterator #32587

Closed
asfimport opened this issue Aug 4, 2022 · 3 comments
Closed

[C++] Expose RecordBatchReader::MakeFromIterator #32587

asfimport opened this issue Aug 4, 2022 · 3 comments

Comments

@asfimport
Copy link
Collaborator

It's unclear why this isn't public to begin with. Perhaps at the time, Iterator wasn't considered public, but now we are using it in public headers.

class SimpleRecordBatchReader : public RecordBatchReader {

Reporter: Will Jones / @wjones127
Assignee: Will Jones / @wjones127

PRs and other links:

Note: This issue was originally created as ARROW-17310. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
What's the purpose of exposing the class vs providing another overload of Make()? (For subclassing?)

@asfimport
Copy link
Collaborator Author

Will Jones / @wjones127:
Oh I think that's a good approach too; I'd be fine with that.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Issue resolved by pull request 13798
#13798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants