Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17310: [C++] Expose RBR:Make() from Iterator<RB> #13798

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

wjones127
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm
Copy link
Member

lidavidm commented Aug 5, 2022

Looks like the integration test failure is legitimate, though: adding the overload makes a call ambiguous. Maybe it should be MakeFromIterator then?

@lidavidm lidavidm merged commit c1af787 into apache:master Aug 5, 2022
@wjones127 wjones127 deleted the ARROW-17310-RBR-from-iterator branch August 5, 2022 20:33
@ursabot
Copy link

ursabot commented Aug 5, 2022

Benchmark runs are scheduled for baseline = 9f1b559 and contender = c1af787. c1af787 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.41% ⬆️0.0%] test-mac-arm
[Finished ⬇️3.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.53% ⬆️0.64%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c1af7872 ec2-t3-xlarge-us-east-2
[Finished] c1af7872 test-mac-arm
[Finished] c1af7872 ursa-i9-9960x
[Finished] c1af7872 ursa-thinkcentre-m75q
[Finished] 9f1b559d ec2-t3-xlarge-us-east-2
[Failed] 9f1b559d test-mac-arm
[Finished] 9f1b559d ursa-i9-9960x
[Finished] 9f1b559d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 5, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants