Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Fix parquet_static dependencies #32665

Closed
asfimport opened this issue Aug 12, 2022 · 1 comment
Closed

[C++][Parquet] Fix parquet_static dependencies #32665

asfimport opened this issue Aug 12, 2022 · 1 comment

Comments

@asfimport
Copy link
Collaborator

See also: microsoft/vcpkg#22552 (comment)

I tried #22552 (comment) (that is based on Apache Arrow 7.0.0).

The following dependencies are missed from link command line:

  • vcpkg_installed/x64-linux/debug/lib/libthriftd.a
  • vcpkg_installed/x64-linux/debug/lib/liblz4d.a
  • vcpkg_installed/x64-linux/debug/lib/libbrotli\{enc,dec,common\}-static.a

It seems that thrift::thrift, lz4::lz4 and unofficial::brotli::brotli\{enc,dec,common\}-static are missed in arrow_static dependencies:

$ grep INTERFACE_LINK_LIBRARIES vcpkg_installed/x64-linux/share/arrow/ArrowTargets.cmake 
INTERFACE_LINK_LIBRARIES "OpenSSL::Crypto;OpenSSL::SSL;BZip2::BZip2;Snappy::snappy;ZLIB::ZLIB;zstd::libzstd_static;re2::re2;Threads::Threads;rt;\$<LINK_ONLY:>"

I'm not sure that this is a problem in Apache Arrow's CMake configuration or patches in vcpkg.

Reporter: Kouhei Sutou / @kou
Assignee: Kouhei Sutou / @kou

PRs and other links:

Note: This issue was originally created as ARROW-17394. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Issue resolved by pull request 13863
#13863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants