ARROW-17394: [C++][Parquet] Fix parquet_static dependencies #13863
Conversation
|
|
parquet_static needs Thrift because cpp/src/parquet/thrift_internal.h uses Thrift. See also: microsoft/vcpkg#22552 (comment) We can test this by the following command lines: $ cd cpp/examples/parquet/parquet_arrow $ export Arrow_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ export Parquet_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ cmake -S . -B build -DPARQUET_LINK_SHARED=OFF $ cmake --build build --verbose I also noticed that OpenTelemetry related dependencies are also missed because I usually use -DARROW_WITH_OPENTELEMETRY=ON option for Apache Arrow development. The problem is also fixed in this.
kou
force-pushed
the
cpp-parquet-static-missing-depdenency
branch
from
9b23141
to
d6c578a
Compare
|
Benchmark runs are scheduled for baseline = 4e48110 and contender = 7726335. 7726335 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…3863) parquet_static needs Thrift because cpp/src/parquet/thrift_internal.h uses Thrift. See also: microsoft/vcpkg#22552 (comment) We can test this by the following command lines: $ cd cpp/examples/parquet/parquet_arrow $ export Arrow_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ export Parquet_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ cmake -S . -B build -DPARQUET_LINK_SHARED=OFF $ cmake --build build --verbose I also noticed that OpenTelemetry related dependencies are also missed because I usually use -DARROW_WITH_OPENTELEMETRY=ON option for Apache Arrow development. The problem is also fixed in this. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…3863) parquet_static needs Thrift because cpp/src/parquet/thrift_internal.h uses Thrift. See also: microsoft/vcpkg#22552 (comment) We can test this by the following command lines: $ cd cpp/examples/parquet/parquet_arrow $ export Arrow_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ export Parquet_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow $ cmake -S . -B build -DPARQUET_LINK_SHARED=OFF $ cmake --build build --verbose I also noticed that OpenTelemetry related dependencies are also missed because I usually use -DARROW_WITH_OPENTELEMETRY=ON option for Apache Arrow development. The problem is also fixed in this. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
parquet_static needs Thrift because cpp/src/parquet/thrift_internal.h
uses Thrift.
See also:
microsoft/vcpkg#22552 (comment)
We can test this by the following command lines:
I also noticed that OpenTelemetry related dependencies are also missed
because I usually use -DARROW_WITH_OPENTELEMETRY=ON option for Apache
Arrow development. The problem is also fixed in this.