Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Adding Fetch Node FromProto #32763

Closed
Tracked by #32762
asfimport opened this issue Aug 23, 2022 · 2 comments · Fixed by #34651
Closed
Tracked by #32762

[C++] Adding Fetch Node FromProto #32763

asfimport opened this issue Aug 23, 2022 · 2 comments · Fixed by #34651

Comments

@asfimport
Copy link
Collaborator

Serializing FetchNode with Substrait. 

Reporter: Vibhatha Lakmal Abeykoon / @vibhatha

Note: This issue was originally created as ARROW-17503. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
This seems like it will be tricky. The fetch node is a sink node. The consumer currently expects sink nodes to come from the caller. I'm not sure of a great way to work around this.

Brainstorming on a currently meeting-fried brain I might think something like...

  • The FromProto for relation returns a current ordering and fetch info

  • Note, if FromProto is called and there is already an ordering / fetch info then it should be an error as Acero can't handle this

  • The ordering / fetch info is passed on to the declaration factory in addition to the other two inputs

  • The declaration factories (at least the consuming sink one) is extended so that, if an ordering / fetch info is present, then it uses the appropriate sink node.

    Maybe ordering / fetch info could be part of declaration info? CC @bkietz

@asfimport
Copy link
Collaborator Author

Apache Arrow JIRA Bot:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@pitrou pitrou added this to the 13.0.0 milestone May 22, 2023
pitrou pushed a commit that referenced this issue May 22, 2023
This does not support the clustered sort direction, custom sort functions, or complex (non-reference) expressions as sort keys.
* Closes: #32763

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants