[C++] Arrow io memory_benchmark does not compile if SIMD level is NEON

[asfimport]

When compiling Arrow with the following parameter:

-DARROW_BUILD_BENCHMARKS_REFERENCE="ON"

I get this error and other similar ones:

cpp/src/arrow/io/memory_benchmark.cc:244:26: error: use of undeclared identifier 'Read'; did you mean 'read'?
using ApplyFn = decltype(Read);

 

The reason is that memory_benchmark.cc does not define the Read function, and others, if the SIMD level is NEON (ARROW_HAVE_NEON is true).

Reporter: Aldrin Montana / @drin
Assignee: Aldrin Montana / @drin

PRs and other links:

• GitHub Pull Request #14036

_{Note: This issue was originally created as ARROW-17598. Please see the migration documentation for further details.}

[asfimport]

Aldrin Montana / @drin:
I think the easiest thing to do would be to change cmake to not add the benchmark if the SIMD level is NEON:

diff --git a/cpp/src/arrow/io/CMakeLists.txt b/cpp/src/arrow/io/CMakeLists.txt
index 33de37c84..ddf10078b 100644
--- a/cpp/src/arrow/io/CMakeLists.txt
+++ b/cpp/src/arrow/io/CMakeLists.txt
@@ -36,7 +36,8 @@ add_arrow_test(memory_test PREFIX "arrow-io") add_arrow_benchmark(file_benchmark PREFIX "arrow-io")-if(NOT (${ARROW_SIMD_LEVEL} STREQUAL "NONE"))
+if(NOT (${ARROW_SIMD_LEVEL} STREQUAL "NONE") AND
+   NOT (${ARROW_SIMD_LEVEL} STREQUAL "NEON"))
   # This benchmark either requires SSE4.2 or ARMV8 SIMD to be enabled
   add_arrow_benchmark(memory_benchmark PREFIX "arrow-io")
 endif()

[asfimport]

Yibo Cai / @cyb70289:
Thanks @drin, will you open a PR?

[asfimport]

Aldrin Montana / @drin:
sounds good @cyb70289. I wasn't sure if it would need any more discussion (which is why I made a JIRA instead of submitted a MINOR pr).

I opened a PR, but I don't think the CI will exercise it, so not sure what to do about that. Let me know if you'd like any other follow up!

[asfimport]

Yibo Cai / @cyb70289:
Issue resolved by pull request 14036
#14036