ARROW-17598: [C++] Skip memory_benchmark if SIMD level is NEON #14036
Conversation
Added an extra check if SIMD_LEVEL is "NEON" because arrow/io/memory_benchmark does not provide definitions for those SIMD instructions.
|
as mentioned in ARROW-17598, this bug requires the flag: |
|
We do support Arm in memory benchmark. But the code looks obsolete and doesn't compile per my test with clang-12 aarch64. It's okay to disable this test on Arm as a workaround. |
|
Is the Lint CI error related to this PR? EDIT: Looks like cmake format error.
|
fixing cmake style
|
finally got the cmake-format linter to work |
|
CI errors are not related |
|
Benchmark runs are scheduled for baseline = f4e79b1 and contender = 3338d99. 3338d99 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…e#14036) Added an extra check if SIMD_LEVEL is "NEON" because arrow/io/memory_benchmark does not provide definitions for those SIMD instructions. Authored-by: Aldrin M <octalene.dev@pm.me> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
…e#14036) Added an extra check if SIMD_LEVEL is "NEON" because arrow/io/memory_benchmark does not provide definitions for those SIMD instructions. Authored-by: Aldrin M <octalene.dev@pm.me> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Added an extra check if SIMD_LEVEL is "NEON" because
arrow/io/memory_benchmark does not provide definitions for those SIMD
instructions.