Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation][Developer Tools] Add CODEOWNERS file #33621

Closed
assignUser opened this issue Jan 11, 2023 · 0 comments · Fixed by #33622
Closed

[Documentation][Developer Tools] Add CODEOWNERS file #33621

assignUser opened this issue Jan 11, 2023 · 0 comments · Fixed by #33622
Assignees
@assignUser
Labels
Component: Developer Tools Component: Documentation Type: enhancement
Milestone
12.0.0

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

Adding a CODEOWNERS file will allow committers to be automatically requested for reviews that they are interested in (based on touched files). This also removes the burden on finding an (initial) reviewer for a PR for contributors which is a major block in the arrow dev workflow, especially for new contributors.

Note that adding a CODEOWNERS file will not automatically activate the branch protection rules to enforce a codeowner review on the respective code.

Documentation: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Component(s)

Developer Tools, Documentation
@assignUser assignUser mentioned this issue Jan 11, 2023
Open
@github-actions github-actions bot mentioned this issue Jan 11, 2023
Merged
raulcd added a commit that referenced this issue Jan 16, 2023
@assignUser @lidavidm
@kou @raulcd @wjones127 @westonpace @paleolimbot
GH-33621: [Documentation][Developer Tools] Add CODEOWNERS file (#33622)
bff9e5e 
# Rationale for this change
CODEOWNERS will lift the burden of finding an initial reviewer for a PR from the contributor and enable committers to basically "subscribe" to a selection of PRs based on their interests/competence within the monorepo without having to watch _all_ notifications for the repo.

# What changes are included in this PR?

I have added a rough structure for the file and added myself to a selection of the patterns. Any committer please feel free to add yourself via suggestion or direct push to this branch.

* Closes: #33621

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd raulcd added this to the 12.0.0 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: Developer Tools Component: Documentation Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33621: [Documentation][Developer Tools] Add CODEOWNERS file assignUser/arrow
2 participants
@raulcd @assignUser