Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Does the dataset feature have a hard dependency on parquet? #33657

Closed
autoantwort opened this issue Jan 13, 2023 · 3 comments · Fixed by #33665
Closed

[C++] Does the dataset feature have a hard dependency on parquet? #33657

autoantwort opened this issue Jan 13, 2023 · 3 comments · Fixed by #33665
Assignees
@kou
Labels
Component: C++ Type: usage Issue is a user question
Milestone
11.0.0

Comments

@autoantwort
Copy link

Describe the usage question you have. Please include as many useful details as possible.

C++: There is the option ARROW_DATASET. Does setting this to ON also require setting ARROW_PARQUET to ON?
Rationale: The file arrow-dataset.pc contains a hard dependency to parquet.

PS: I am only a vcpkg maintainer and not an arrow user.

Component(s)

C++
@autoantwort autoantwort added the Type: usage Issue is a user question label Jan 13, 2023
@westonpace
Copy link
Member

It should not. They were designed to be separable.

@westonpace
Copy link
Member

Though maybe there is some nuance. If the datasets shared library is compiled with ARROW_PARQUET=ON then it will fail unless the parquet shared library is present.

If the datasets shared library is compiled with ARROW_PARQUET=OFF then it will not fail.

kou added a commit to kou/arrow that referenced this issue Jan 15, 2023
@kou
apacheGH-33657: [C++] arrow-dataset.pc doesn't depend on parquet.pc w…
ca97309 
…ithout ARROW_PARQUET=ON
@kou kou mentioned this issue Jan 15, 2023
Merged
@kou
Copy link
Member

kou commented Jan 15, 2023

It's a bug of arrow-dataset.pc.
#33665 fixes this.

@kou kou added this to the 11.0.0 milestone Jan 15, 2023
kou added a commit that referenced this issue Jan 15, 2023
@kou
GH-33657: [C++] arrow-dataset.pc doesn't depend on parquet.pc without…
b743ee9 
… ARROW_PARQUET=ON (#33665)

# Which issue does this PR close?

Closes #33657

# Rationale for this change

If `arrow-dataset.pc` has `parquet` in `Requires` without `ARROW_PARQUET=ON`, the `arrow-dataset.pc` is invalid.

# What changes are included in this PR?

This PR includes `ARROW_PARQUET=ON` check to determine suitable `Requires` value.

# Are these changes tested?

Yes.

# Are there any user-facing changes?

Yes. `arrow-dataset.pc` without `ARROW_PARQUET=ON` users can use `arrow-dataset.pc` with this.
* Closes: #33657

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou changed the title [c++] Does the dataset feature have a hard dependency on parquet? [C++] Does the dataset feature have a hard dependency on parquet? Jan 15, 2023
@autoantwort autoantwort mentioned this issue Jan 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: usage Issue is a user question
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-33657: [C++] arrow-dataset.pc doesn't depend on parquet.pc without ARROW_PARQUET=ON kou/arrow
3 participants
@kou @westonpace @autoantwort