Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Standardize as-of-join convention for past and future tolerance #33673

Closed
rtpsw opened this issue Jan 15, 2023 · 1 comment · Fixed by #33676
Closed

[C++] Standardize as-of-join convention for past and future tolerance #33673

rtpsw opened this issue Jan 15, 2023 · 1 comment · Fixed by #33676
Assignees
@rtpsw
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented Jan 15, 2023 •
edited
Loading

Describe the enhancement requested

Currently, as-of-join considered a positive tolerance as past (for historical reasons) and negative as future (as it was recently added), but the standard convention is the opposite. This is a breaking change in an experimental API.

Component(s)

C++
@rtpsw
Copy link
Contributor Author

rtpsw commented Jan 15, 2023

cc @westonpace @icexelloss

rtpsw added a commit to rtpsw/arrow that referenced this issue Jan 15, 2023
@rtpsw
apacheGH-33673: [C++] Standardize as-of-join convention for past and …
30f4f14 
…future tolerance
@rtpsw rtpsw mentioned this issue Jan 15, 2023
Merged
rtpsw added a commit to rtpsw/arrow that referenced this issue Jan 28, 2023
@rtpsw
Merge branch 'master' into apacheGH-33673
d92cf69
rtpsw added a commit to rtpsw/arrow that referenced this issue Jan 28, 2023
@rtpsw
Merge branch 'master' into apacheGH-33673
0211ed4
westonpace pushed a commit that referenced this issue Jan 30, 2023
@rtpsw
GH-33673: [C++] Standardize as-of-join convention for past and future…
64a48c9 
… tolerance (#33676)

See #33673
* Closes: #33673

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Jan 30, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@rtpsw @sjperkins
apacheGH-33673: [C++] Standardize as-of-join convention for past and …
4586cc1 
…future tolerance (apache#33676)

See apache#33673
* Closes: apache#33673

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@rtpsw
apacheGH-33673: [C++] Standardize as-of-join convention for past and …
5d52ecf 
…future tolerance (apache#33676)

See apache#33673
* Closes: apache#33673

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33673: [C++] Standardize as-of-join convention for past and future tolerance rtpsw/arrow
2 participants
@westonpace @rtpsw