You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The old tracing model starts a span when a node starts and ends the span when the node marks itself finished. Some nodes start an additional InputReceived span with the above mentioned span as parent. This makes it rather difficult to tell where time is actually being spent because large blocks of the span represent idle time. It does not accurately reflect time spent.
I've would like to change the model to use async scheduler tasks as spans. In practice, this would mean that there is now a span per fragment. It may have child spans for each of the nodes that runs on the fragment (simple nodes may just mark their execution as an event). This also will allow us to get rid of the ExecNode::finsihed_ future as they are no longer really necessary (they can show up as "waiting for finish" spans that don't really provide any useful information).
Component(s)
C++
The text was updated successfully, but these errors were encountered:
This PR does two things. First, it requires that all "tasks" (for the AsyncTaskScheduler, not the executor) have a name. Second, it simplifies and cleans up the way that exec nodes report their tracing using a `TracedNode` helper class.
* Closes: #33737
Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
This PR does two things. First, it requires that all "tasks" (for the AsyncTaskScheduler, not the executor) have a name. Second, it simplifies and cleans up the way that exec nodes report their tracing using a `TracedNode` helper class.
* Closes: apache#33737
Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Describe the enhancement requested
The old tracing model starts a span when a node starts and ends the span when the node marks itself finished. Some nodes start an additional InputReceived span with the above mentioned span as parent. This makes it rather difficult to tell where time is actually being spent because large blocks of the span represent idle time. It does not accurately reflect time spent.
I've would like to change the model to use async scheduler tasks as spans. In practice, this would mean that there is now a span per fragment. It may have child spans for each of the nodes that runs on the fragment (simple nodes may just mark their execution as an event). This also will allow us to get rid of the ExecNode::finsihed_ future as they are no longer really necessary (they can show up as "waiting for finish" spans that don't really provide any useful information).
Component(s)
C++
The text was updated successfully, but these errors were encountered: