You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RecordReader's methods don't return err, so there's no way to propagate errors. For this reason, exported streams in the C Data Interface have no way of returning errors, either.
Changing the interface would of course be a breaking change. The alternative is to declare this:
type ClosableRecordReader interface {
RecordReader
Closable
}
which gives us one place to report errors (at the end).
Component(s)
Go
The text was updated successfully, but these errors were encountered:
At this point we might as well add the Err() error method to the array.RecordReader interface, this would allow us to potentially bring the ipc.Reader to be an array.RecordReader also without sacrificing the ability to retrieve errors.
lidavidm
added a commit
to lidavidm/arrow
that referenced
this issue
Jan 19, 2023
### Rationale for this change
Add Err() to the RecordReader interface so we can report errors.
### Are these changes tested?
This is tested in the C Data Interface.
### Are there any user-facing changes?
**This is a breaking change.**
* Closes: #33789
Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Describe the enhancement requested
RecordReader's methods don't return
err
, so there's no way to propagate errors. For this reason, exported streams in the C Data Interface have no way of returning errors, either.Changing the interface would of course be a breaking change. The alternative is to declare this:
which gives us one place to report errors (at the end).
Component(s)
Go
The text was updated successfully, but these errors were encountered: