Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Conan] Failed to build #33816

Closed
kou opened this issue Jan 21, 2023 · 0 comments · Fixed by #33817
Closed

[CI][Conan] Failed to build #33816

kou opened this issue Jan 21, 2023 · 0 comments · Fixed by #33817
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
12.0.0

Comments

@kou
Copy link
Member

kou commented Jan 21, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/3965984977/jobs/6796278942#step:5:1405

CMake Error at cmake_modules/BuildUtils.cmake:949 (file):
  Error evaluating generator expression:

    $<OR:>

  Parameters to $<OR> must resolve to either '0' or '1'.
Call Stack (most recent call first):
  cmake_modules/BuildUtils.cmake:486 (arrow_add_pkg_config)
  src/arrow/CMakeLists.txt:604 (add_arrow_lib)


CMake Error at cmake_modules/BuildUtils.cmake:949 (file):
  Error evaluating generator expression:

    $<OR:>

  Parameters to $<OR> must resolve to either '0' or '1'.
Call Stack (most recent call first):
  cmake_modules/BuildUtils.cmake:486 (arrow_add_pkg_config)
  src/arrow/CMakeLists.txt:604 (add_arrow_lib)


-- Generating done

Component(s)

C++, Continuous Integration
@kou kou added the Type: bug label Jan 21, 2023
kou added a commit to kou/arrow that referenced this issue Jan 21, 2023
@kou
apacheGH-33816: [CI][Conan] Use TARGET_FILE for portability
cfb966f
@github-actions github-actions bot mentioned this issue Jan 21, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Jan 21, 2023
@kou
apacheGH-33816: [CI][Conan] Use TARGET_FILE for portability
d393378
kou added a commit to kou/arrow that referenced this issue Jan 21, 2023
@kou
apacheGH-33816: [CI][Conan] Use TARGET_FILE for portability
accaada
kou added a commit that referenced this issue Jan 21, 2023
@kou
GH-33816: [CI][Conan] Use TARGET_FILE for portability (#33817)
63967ac 
### What changes are included in this PR?

Use `$<TARGET_FILE>` instead of manual library path resolution. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #33816

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Jan 21, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@kou @sjperkins
apacheGH-33816: [CI][Conan] Use TARGET_FILE for portability (apache#3…
bf8be3c 
…3817)

### What changes are included in this PR?

Use `$<TARGET_FILE>` instead of manual library path resolution. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#33816

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33816: [CI][Conan] Use TARGET_FILE for portability kou/arrow
1 participant
@kou