Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Improve SQLite Flight SQL example and provide simple mainprog #33840

Closed
zeroshade opened this issue Jan 23, 2023 · 0 comments · Fixed by #33841
Closed

[Go] Improve SQLite Flight SQL example and provide simple mainprog #33840

zeroshade opened this issue Jan 23, 2023 · 0 comments · Fixed by #33841

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

To assist with testing and facilitate easier ADBC testing, the Go SQLite Flight SQL example can be expanded to provide a simple mainprog to launch it (which can then be installed with go install or go get). This requires a couple improvements to the example to better support features of Flight SQL and not be as limited by the types it accepts (such as unions).

Component(s)

Developer Tools, Go

zeroshade added a commit to zeroshade/arrow that referenced this issue Jan 23, 2023
zeroshade added a commit that referenced this issue Jan 23, 2023
…#33841)

### Rationale for this change

Better facilitate Flight SQL testing by providing a simple mainprog which can be easily installed via `go get` or `go install` for testing and for running CI against.

### What changes are included in this PR?

Improvements to the FlightSQL SQLite Go example and the creation of a mainprog at github.com/apache/arrow/go/v11/arrow/flight/flightsql/cmd/sqlite_flightsql_server

### Are these changes tested?

Covered by existing tests in sqlite_server_test.go

* Closes: #33840

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Jan 23, 2023
westonpace pushed a commit to westonpace/arrow that referenced this issue Jan 25, 2023
…inprog (apache#33841)

### Rationale for this change

Better facilitate Flight SQL testing by providing a simple mainprog which can be easily installed via `go get` or `go install` for testing and for running CI against.

### What changes are included in this PR?

Improvements to the FlightSQL SQLite Go example and the creation of a mainprog at github.com/apache/arrow/go/v11/arrow/flight/flightsql/cmd/sqlite_flightsql_server

### Are these changes tested?

Covered by existing tests in sqlite_server_test.go

* Closes: apache#33840

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
…inprog (apache#33841)

### Rationale for this change

Better facilitate Flight SQL testing by providing a simple mainprog which can be easily installed via `go get` or `go install` for testing and for running CI against.

### What changes are included in this PR?

Improvements to the FlightSQL SQLite Go example and the creation of a mainprog at github.com/apache/arrow/go/v11/arrow/flight/flightsql/cmd/sqlite_flightsql_server

### Are these changes tested?

Covered by existing tests in sqlite_server_test.go

* Closes: apache#33840

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant