Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Python] Implementation of the dlpack #33984

Closed
Tracked by #33982
AlenkaF opened this issue Feb 1, 2023 · 0 comments · Fixed by #38472
Closed
Tracked by #33982

[C++][Python] Implementation of the dlpack #33984

AlenkaF opened this issue Feb 1, 2023 · 0 comments · Fixed by #38472
Assignees
@AlenkaF
Labels
Component: C++ Component: Python Type: enhancement
Milestone
15.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Feb 1, 2023

Describe the enhancement requested

Python array API standard selected DLPack as the best candidate for the Python array/tensor interchange protocol. It would be good to have that implemented in C++ or Cython for PyArrow as well.

Component(s)

C++
@AlenkaF AlenkaF mentioned this issue Feb 1, 2023
Closed
5 tasks
@mattijn mattijn mentioned this issue Jun 4, 2023
Open
@AlenkaF AlenkaF mentioned this issue Sep 19, 2023
Merged
@AlenkaF AlenkaF self-assigned this Oct 16, 2023
@github-actions github-actions bot mentioned this issue Oct 26, 2023
Merged
@AlenkaF AlenkaF mentioned this issue Nov 23, 2023
Open
This was referenced Dec 19, 2023
Open
Open
Open
pitrou added a commit that referenced this issue Dec 19, 2023
@AlenkaF @pitrou @jorisvandenbossche
GH-33984: [C++][Python] DLPack implementation for Arrow Arrays (produ…
6c326db 
…cer) (#38472)

### Rationale for this change

DLPack is selected for Array API protocol so it is important to have it implemented for Arrow/PyArrow Arrays also. This is possible for primitive type arrays (int, uint and float) with no validity buffer. Device support is not in scope of this PR (CPU only). 

### What changes are included in this PR?

- `ExportArray` and `ExportDevice` methods on Arrow C++ Arrays
- `__dlpack__` method on the base PyArrow Array class exposing `ExportArray` method
-  `__dlpack_device__` method on the base PyArrow Array class exposing `ExportDevice` method

### Are these changes tested?

Yes, tests are added to `dlpack_test.cc` and `test_array.py`.

### Are there any user-facing changes?

No.

* Closes: #33984

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 15.0.0 milestone Dec 19, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@AlenkaF @pitrou
@jorisvandenbossche @clayburn
apacheGH-33984: [C++][Python] DLPack implementation for Arrow Arrays …
ffa4b72 
…(producer) (apache#38472)

### Rationale for this change

DLPack is selected for Array API protocol so it is important to have it implemented for Arrow/PyArrow Arrays also. This is possible for primitive type arrays (int, uint and float) with no validity buffer. Device support is not in scope of this PR (CPU only). 

### What changes are included in this PR?

- `ExportArray` and `ExportDevice` methods on Arrow C++ Arrays
- `__dlpack__` method on the base PyArrow Array class exposing `ExportArray` method
-  `__dlpack_device__` method on the base PyArrow Array class exposing `ExportDevice` method

### Are these changes tested?

Yes, tests are added to `dlpack_test.cc` and `test_array.py`.

### Are there any user-facing changes?

No.

* Closes: apache#33984

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@AlenkaF @pitrou
@jorisvandenbossche @dgreiss
apacheGH-33984: [C++][Python] DLPack implementation for Arrow Arrays …
caae854 
…(producer) (apache#38472)

### Rationale for this change

DLPack is selected for Array API protocol so it is important to have it implemented for Arrow/PyArrow Arrays also. This is possible for primitive type arrays (int, uint and float) with no validity buffer. Device support is not in scope of this PR (CPU only). 

### What changes are included in this PR?

- `ExportArray` and `ExportDevice` methods on Arrow C++ Arrays
- `__dlpack__` method on the base PyArrow Array class exposing `ExportArray` method
-  `__dlpack_device__` method on the base PyArrow Array class exposing `ExportDevice` method

### Are these changes tested?

Yes, tests are added to `dlpack_test.cc` and `test_array.py`.

### Are there any user-facing changes?

No.

* Closes: apache#33984

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: C++ Component: Python Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-33984: [C++][Python] DLPack implementation for Arrow Arrays (producer) AlenkaF/arrow
3 participants
@jorisvandenbossche @pitrou @AlenkaF