Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Clean up BloomFilter API #34078

Closed
Tracked by #15164
wjones127 opened this issue Feb 8, 2023 · 1 comment · Fixed by #33995
Closed
Tracked by #15164

[C++][Parquet] Clean up BloomFilter API #34078

wjones127 opened this issue Feb 8, 2023 · 1 comment · Fixed by #33995
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet
Milestone
12.0.0

Comments

@wjones127
Copy link
Member

No description provided.

This was referenced Feb 8, 2023
Closed
Merged
@wjones127 wjones127 assigned wjones127 and unassigned wjones127 Feb 8, 2023
@kou kou changed the title Clean up BloomFilter API [C++][Parquet] Clean up BloomFilter API Feb 8, 2023
@mapleFU
Copy link
Member

mapleFU commented Feb 9, 2023

take

wjones127 pushed a commit that referenced this issue Feb 9, 2023
@mapleFU
GH-34078: [C++][Parquet] Minor API improvements for BloomFilter (#33995)
d512dd2 
### Rationale for this change

* adding a interface `OptimalNumOfBytes`, because `OptimalNumOfBits` is confusing...
* BloomFilter accept a `MemoryPool` as input argument

### What changes are included in this PR?

### Are these changes tested?

They're already tested...

### Are there any user-facing changes?

No. (But user may misuse `BloomFilter::Init` previously)

* Closes: #34078
* Closes: #34078

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
@wjones127 wjones127 added this to the 12.0.0 milestone Feb 9, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@mapleFU @sjperkins
apacheGH-34078: [C++][Parquet] Minor API improvements for BloomFilter (…
65c84a8 
…apache#33995)

### Rationale for this change

* adding a interface `OptimalNumOfBytes`, because `OptimalNumOfBits` is confusing...
* BloomFilter accept a `MemoryPool` as input argument

### What changes are included in this PR?

### Are these changes tested?

They're already tested...

### Are there any user-facing changes?

No. (But user may misuse `BloomFilter::Init` previously)

* Closes: apache#34078
* Closes: apache#34078

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@mapleFU
apacheGH-34078: [C++][Parquet] Minor API improvements for BloomFilter (…
fcf86b2 
…apache#33995)

### Rationale for this change

* adding a interface `OptimalNumOfBytes`, because `OptimalNumOfBits` is confusing...
* BloomFilter accept a `MemoryPool` as input argument

### What changes are included in this PR?

### Are these changes tested?

They're already tested...

### Are there any user-facing changes?

No. (But user may misuse `BloomFilter::Init` previously)

* Closes: apache#34078
* Closes: apache#34078

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@mapleFU @fatemehp
apacheGH-34078: [C++][Parquet] Minor API improvements for BloomFilter (…
a78cfc1 
…apache#33995)

### Rationale for this change

* adding a interface `OptimalNumOfBytes`, because `OptimalNumOfBits` is confusing...
* BloomFilter accept a `MemoryPool` as input argument

### What changes are included in this PR?

### Are these changes tested?

They're already tested...

### Are there any user-facing changes?

No. (But user may misuse `BloomFilter::Init` previously)

* Closes: apache#34078
* Closes: apache#34078

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34078: [C++][Parquet] Minor API improvements for BloomFilter mapleFU/arrow
2 participants
@wjones127 @mapleFU