Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use special URI to allow calling UDFs via Substrait #34122

Closed
westonpace opened this issue Feb 10, 2023 · 0 comments · Fixed by #34288
Closed

[C++] Use special URI to allow calling UDFs via Substrait #34122

westonpace opened this issue Feb 10, 2023 · 0 comments · Fixed by #34288
Assignees
@westonpace
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@westonpace
Copy link
Member

Describe the enhancement requested

We should key on a special URI (e.g. https://apache.org/arrow/udf) to recognize that a Substrait call is actually looking for an Acero registered UDF. Then we can bypass the normal mapping and just search for the function by name and pass all arguments as-is.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Feb 22, 2023
Merged
westonpace added a commit that referenced this issue Feb 23, 2023
@westonpace
GH-34122: [C++] Allow calling function registry functions without req…
a9552d1 
…uiring a Substrait mapping (#34288)

This introduces the special URI `urn:arrow:substrait_simple_extension_function` which can be interpreted as "just call a function from the Arrow function registry by name".  It should only be used in plans where the consumer is Acero as these plans will not likely make any sense elsewhere.
* Closes: #34122

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Feb 23, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@westonpace @fatemehp
apacheGH-34122: [C++] Allow calling function registry functions witho…
9efb615 
…ut requiring a Substrait mapping (apache#34288)

This introduces the special URI `urn:arrow:substrait_simple_extension_function` which can be interpreted as "just call a function from the Arrow function registry by name".  It should only be used in plans where the consumer is Acero as these plans will not likely make any sense elsewhere.
* Closes: apache#34122

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
1 participant
@westonpace