Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] [Python] Fix improper initialization of ConversionOptions #34150

Closed
rtpsw opened this issue Feb 12, 2023 · 2 comments · Fixed by #34156 or #34209
Closed

[C++] [Python] Fix improper initialization of ConversionOptions #34150

rtpsw opened this issue Feb 12, 2023 · 2 comments · Fixed by #34156 or #34209
Assignees
@rtpsw
Labels
Component: C++ Component: Python Type: bug
Milestone
12.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented Feb 12, 2023

Describe the bug, including details regarding any error messages, version, and platform.

In a debugging session, I observed that ConversionOptions being passed from _substrait.pyx was improperly initialized, leading to a SIGSEGV. In particular, the extension provider member had a different value than default_extension_provider() returns. I suspect this is because ConversionOptions is currently a POD, whose initialization of the extension provider member occurs before that of g_default_extension_provider being returned from default_extension_provider. The fix should ensure correct order of initialization. In addition, the definition of CConversionOptions in libarrow_substrait.pxd should be updated to match ConversionOptions.

Component(s)

C++, Python
@rtpsw
Copy link
Contributor Author

rtpsw commented Feb 12, 2023

take

@rtpsw
Copy link
Contributor Author

rtpsw commented Feb 12, 2023

cc @westonpace, @icexelloss

rtpsw added a commit to rtpsw/arrow that referenced this issue Feb 13, 2023
@rtpsw
apacheGH-34150: [C++] [Python] Fix improper initialization of Convers…
5fffcbd 
…ionOptions
@rtpsw rtpsw mentioned this issue Feb 13, 2023
Merged
rtpsw added a commit to rtpsw/arrow that referenced this issue Feb 13, 2023
@rtpsw
Merge branch 'master' into apacheGH-34150
a9efb62
@github-actions github-actions bot mentioned this issue Feb 15, 2023
Merged
westonpace pushed a commit that referenced this issue Feb 17, 2023
@rtpsw
GH-34150: [C++] [Python] Fix improper initialization of ConversionOpt…
11ae62a 
…ions (#34156)

This PR fixes a bug that caused a crash. See #34150 for more details.
* Closes: #34150

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Feb 17, 2023
westonpace added a commit that referenced this issue Feb 21, 2023
@westonpace
GH-34150: [C++] Fix error due to improper initialization of conversio…
5c61cbc 
…n option defaults (#34209)

* Closes: #34150

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@rtpsw @fatemehp
apacheGH-34150: [C++] [Python] Fix improper initialization of Convers…
6bcb1db 
…ionOptions (apache#34156)

This PR fixes a bug that caused a crash. See apache#34150 for more details.
* Closes: apache#34150

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@westonpace @fatemehp
apacheGH-34150: [C++] Fix error due to improper initialization of con…
09dba65 
…version option defaults (apache#34209)

* Closes: apache#34150

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Component: Python Type: bug
Projects
None yet
Milestone
12.0.0
2 participants
@westonpace @rtpsw