Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CI] Typo in build_orc CMake macro #34163

Closed
noahfrn opened this issue Feb 13, 2023 · 1 comment · Fixed by #34164
Closed

[C++][CI] Typo in build_orc CMake macro #34163

noahfrn opened this issue Feb 13, 2023 · 1 comment · Fixed by #34164
Assignees
@noahfrn
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
12.0.0

Comments

@noahfrn
Copy link
Contributor

noahfrn commented Feb 13, 2023

Describe the bug, including details regarding any error messages, version, and platform.

I've found a typo in the build_orc macro in the ThirdPartyToolchain, which means that the orc build command defaults to downloading zstd, instead of using the same configuration as the main arrow build command.

"-DZSTD_HOME=${ORZ_ZSTD_ROOT}") (From here)

Component(s)

C++, Continuous Integration
@noahfrn
Copy link
Contributor Author

noahfrn commented Feb 13, 2023

take

@github-actions github-actions bot mentioned this issue Feb 13, 2023
Merged
@kou kou added this to the 12.0.0 milestone Feb 15, 2023
kou added a commit that referenced this issue Feb 15, 2023
@noahfrn @kou
GH-34163: [C++][CI] Ensure using the same Zstandard with bundled ORC (#…
13a9ad9 
…34164)

This change fixes a variable name and specifies more Zstandard related parameters explicitly to use the same Zstandard used in Apache Arrow itself.

* Closes: #34163

Lead-authored-by: NoahFournier <63198198+NoahFournier@users.noreply.github.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@noahfrn @kou
apacheGH-34163: [C++][CI] Ensure using the same Zstandard with bundle…
d040e7e 
…d ORC (apache#34164)

This change fixes a variable name and specifies more Zstandard related parameters explicitly to use the same Zstandard used in Apache Arrow itself.

* Closes: apache#34163

Lead-authored-by: NoahFournier <63198198+NoahFournier@users.noreply.github.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@noahfrn @kou @fatemehp
apacheGH-34163: [C++][CI] Ensure using the same Zstandard with bundle…
49f6015 
…d ORC (apache#34164)

This change fixes a variable name and specifies more Zstandard related parameters explicitly to use the same Zstandard used in Apache Arrow itself.

* Closes: apache#34163

Lead-authored-by: NoahFournier <63198198+NoahFournier@users.noreply.github.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahfrn noahfrn

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34163: [C++][CI] Ensure using the same Zstandard with bundled ORC noahfrn/arrow
2 participants
@kou @noahfrn