Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Add bindings for JSON format in Dataset #34216

Closed
benibus opened this issue Feb 16, 2023 · 1 comment · Fixed by #34586
Closed

[Python] Add bindings for JSON format in Dataset #34216

benibus opened this issue Feb 16, 2023 · 1 comment · Fixed by #34586
Assignees
@R-JunmingChen
Labels
Component: Python Type: enhancement
Milestone
13.0.0

Comments

@benibus
Copy link
Collaborator

benibus commented Feb 16, 2023

Describe the enhancement requested

#33732 adds C++ support for reading (but not writing) JSON datasets. Once that's finalized, we should expose the new format via Python.

Component(s)

Python
@R-JunmingChen
Copy link
Contributor

take

@R-JunmingChen R-JunmingChen mentioned this issue Mar 16, 2023
Merged
westonpace added a commit that referenced this issue Apr 12, 2023
@R-JunmingChen @westonpace
GH-34216: [Python] Support for reading JSON Datasets With Python (#34586
4963105 
)

This PR supports for reading JSON Datasets With Python. As mentioned in [#34216](#34216), only the reading ability are supported.

Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd.
Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. 

**What changes are included in this PR?**

C++: add inclusion for file_json.h
Python: reference C++ codes and support reading JSON Datasets

**Are these changes tested?**
Yes
6 test samples added in tests/test_dataset.py

* Closes: #34216

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 13.0.0 milestone Apr 12, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@R-JunmingChen @westonpace @liujiacheng777
apacheGH-34216: [Python] Support for reading JSON Datasets With Python (
c7dee48 
apache#34586)

This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported.

Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd.
Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. 

**What changes are included in this PR?**

C++: add inclusion for file_json.h
Python: reference C++ codes and support reading JSON Datasets

**Are these changes tested?**
Yes
6 test samples added in tests/test_dataset.py

* Closes: apache#34216

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@R-JunmingChen @westonpace @ArgusLi
apacheGH-34216: [Python] Support for reading JSON Datasets With Python (
33c792f 
apache#34586)

This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported.

Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd.
Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. 

**What changes are included in this PR?**

C++: add inclusion for file_json.h
Python: reference C++ codes and support reading JSON Datasets

**Are these changes tested?**
Yes
6 test samples added in tests/test_dataset.py

* Closes: apache#34216

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@R-JunmingChen @westonpace @rtpsw
apacheGH-34216: [Python] Support for reading JSON Datasets With Python (
419064c 
apache#34586)

This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported.

Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd.
Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. 

**What changes are included in this PR?**

C++: add inclusion for file_json.h
Python: reference C++ codes and support reading JSON Datasets

**Are these changes tested?**
Yes
6 test samples added in tests/test_dataset.py

* Closes: apache#34216

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-JunmingChen R-JunmingChen

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-34216: [Python] Support for reading JSON Datasets With Python R-JunmingChen/arrow
3 participants
@westonpace @R-JunmingChen @benibus