Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Extra features not found when Arrow is detected with pkg #34228

Closed
westonpace opened this issue Feb 16, 2023 · 0 comments · Fixed by #34229
Closed

[R] Extra features not found when Arrow is detected with pkg #34228

westonpace opened this issue Feb 16, 2023 · 0 comments · Fixed by #34229
Assignees
Milestone

Comments

@westonpace
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

I am well beyond my depth here but I was having trouble getting R to detect that my Arrow build had the datasets feature enabled (I don't normally build R but built it recently to debug an issue and ran into this).

I get the message echo "*** Arrow C++ libraries found via pkg-config at $FOUND_LIB_DIR" so R is finding Arrow that way. However, later, it seems to want to find the extra features in this way:

  # Check for features
  ARROW_OPTS_CMAKE="$LIB_DIR/cmake/Arrow/ArrowOptions.cmake"

  arrow_built_with() {
    # Function to check cmake options for features
    grep -i 'set('"$1"' "ON")' $ARROW_OPTS_CMAKE >/dev/null 2>&1
  }

Since LIB_DIR is unset it does not find the ArrowOptions.cmake file (even though I have one and it is installed). I have a fix that sets LIB_DIR in the pkg-config path and will create a PR but I have no idea if that is the best fix.

Component(s)

R

kou pushed a commit that referenced this issue Feb 17, 2023
* Closes: #34228

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Feb 17, 2023
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
…pache#34229)

* Closes: apache#34228

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
…pache#34229)

* Closes: apache#34228

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants