Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Build error: arrow/dataset/test_util.h: No such file or directory #34269

Closed
abetomo opened this issue Feb 20, 2023 · 1 comment · Fixed by #34285
Closed

[C++] Build error: arrow/dataset/test_util.h: No such file or directory #34269

abetomo opened this issue Feb 20, 2023 · 1 comment · Fixed by #34285
Assignees
@abetomo
Labels
Component: C++ Type: bug
Milestone
12.0.0

Comments

@abetomo
Copy link
Contributor

abetomo commented Feb 20, 2023

Describe the bug, including details regarding any error messages, version, and platform.

An error was displayed when the following command was executed.

$ cmake .. --preset ninja-debug-maximal -DARROW_BUILD_SHARED=OFF -DARROW_BUILD_STATIC=ON
$ cmake --build .

Errors:

/home/xxx/arrow/cpp/src/skyhook/protocol/skyhook_protocol_test.cc:20:10: fatal error: arrow/dataset/test_util.h: No such file or directory
   20 | #include "arrow/dataset/test_util.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

#include "arrow/dataset/test_util_internal.h" seems to be correct.

Component(s)

C++
@kou
Copy link
Member

kou commented Feb 21, 2023 •
edited
Loading

It seems that #34035/#34036 broke this.

abetomo added a commit to abetomo/arrow that referenced this issue Feb 22, 2023
@abetomo
apacheGH-34269: [C++] Fix include file name
d20a347 
The following error occurred.

```
/xxx/arrow/cpp/src/skyhook/protocol/skyhook_protocol_test.cc:20:10: fatal error: arrow/dataset/test_util.h: No such file or directory
   20 | #include "arrow/dataset/test_util.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```

Signed-off-by: abetomo <abe@enzou.tokyo>
@github-actions github-actions bot mentioned this issue Feb 22, 2023
Merged
westonpace pushed a commit that referenced this issue Feb 22, 2023
@abetomo
GH-34269: [C++] Fix include file name (#34285)
bda727f 
### Rationale for this change

I got a "arrow/dataset/test_util.h: No such file or directory" error when building, so I changed it to the correct file name.

### What changes are included in this PR?

Changed include file name.

### Are these changes tested?

I checked that I was able to build because I had an error in the build.

### Are there any user-facing changes?

* Closes: #34269

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Feb 22, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@abetomo @fatemehp
apacheGH-34269: [C++] Fix include file name (apache#34285)
ced9585 
### Rationale for this change

I got a "arrow/dataset/test_util.h: No such file or directory" error when building, so I changed it to the correct file name.

### What changes are included in this PR?

Changed include file name.

### Are these changes tested?

I checked that I was able to build because I had an error in the build.

### Are there any user-facing changes?

* Closes: apache#34269

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abetomo abetomo

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34269: [C++] Fix include file name abetomo/arrow
3 participants
@kou @abetomo @westonpace