Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Failed to build with https://github.com/apache/thrift/archive/v0.16.0.tar.gz #34271

Closed
sharkdtu opened this issue Feb 21, 2023 · 2 comments · Fixed by #34273
Closed

[C++] Failed to build with https://github.com/apache/thrift/archive/v0.16.0.tar.gz #34271

sharkdtu opened this issue Feb 21, 2023 · 2 comments · Fixed by #34273
Assignees
@sharkdtu
Labels
Component: C++ Type: bug
Milestone
12.0.0

Comments

@sharkdtu
Copy link

sharkdtu commented Feb 21, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

i tried to build arrow and found SHA256_CHECKSUM of thrift error. i will make a pr to fix it.

-- Downloading...
   dst='/opt/gluten/ep/build-arrow/build/arrow_ep/cpp/build/thrift_ep-prefix/src/thrift-0.16.0.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://www.apache.org/dyn/closer.cgi?action=download&filename=/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://downloads.apache.org/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://github.com/apache/thrift/archive/v0.16.0.tar.gz'
-- verifying file...
       file='/opt/gluten/ep/build-arrow/build/arrow_ep/cpp/build/thrift_ep-prefix/src/thrift-0.16.0.tar.gz'
-- SHA256 hash of
    /opt/gluten/ep/build-arrow/build/arrow_ep/cpp/build/thrift_ep-prefix/src/thrift-0.16.0.tar.gz
  does not match expected value
    expected: 'f460b5c1ca30d8918ff95ea3eb6291b3951cf518553566088f3f2be8981f6209'
      actual: 'df2931de646a366c2e5962af679018bca2395d586e00ba82d09c0379f14f8e7b'
-- Hash mismatch, removing...
-- Using src='https://apache.claz.org/thrift/0.16.0/thrift-0.16.0.tar.gz'
-- Using src='https://github.com/apache/thrift/archive/v0.16.0.tar.gz'
-- verifying file...
       file='/opt/gluten/ep/build-arrow/build/arrow_ep/cpp/build/thrift_ep-prefix/src/thrift-0.16.0.tar.gz'
-- SHA256 hash of
    /opt/gluten/ep/build-arrow/build/arrow_ep/cpp/build/thrift_ep-prefix/src/thrift-0.16.0.tar.gz
  does not match expected value
    expected: 'f460b5c1ca30d8918ff95ea3eb6291b3951cf518553566088f3f2be8981f6209'
      actual: 'df2931de646a366c2e5962af679018bca2395d586e00ba82d09c0379f14f8e7b'

Component(s)

C++
@sharkdtu sharkdtu mentioned this issue Feb 21, 2023
Closed
@sharkdtu
Copy link
Author

close it, as it may success when download from other source.

@js8544 js8544 mentioned this issue Feb 21, 2023
Merged
@js8544
Copy link
Collaborator

js8544 commented Feb 21, 2023

Hi Shark :). On thrift's github release page it says

The assets listed below are added by Github based on the release tag and they will therefore not match the checkums published on the Thrift project website.

Therefore it shouldn't be considered as a valid thrift source url. I've created #34273 to remove this source.

@kou kou changed the title Failed to build [C++] Failed to build with https://github.com/apache/thrift/archive/v0.16.0.tar.gz Feb 21, 2023
@kou kou reopened this Feb 21, 2023
kou pushed a commit that referenced this issue Feb 21, 2023
@js8544
GH-34271: [C++] Remove Thrift GitHub archive source url (#34273)
ac8e093 
Thirft's [GitHub release files](https://github.com/apache/thrift/releases) do not match the checksum of official source files.

> The assets listed below are added by Github based on the release tag and they will therefore not match the checkums published on the Thrift project website.

Using it as Thrift_SOURCE_URL causes issues such as #34271.
* Closes: #34271

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Feb 21, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@js8544 @fatemehp
apacheGH-34271: [C++] Remove Thrift GitHub archive source url (apache…
8f38567 
…#34273)

Thirft's [GitHub release files](https://github.com/apache/thrift/releases) do not match the checksum of official source files.

> The assets listed below are added by Github based on the release tag and they will therefore not match the checkums published on the Thrift project website.

Using it as Thrift_SOURCE_URL causes issues such as apache#34271.
* Closes: apache#34271

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharkdtu sharkdtu

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
12.0.0
3 participants
@kou @sharkdtu @js8544