-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Allow GcsFileSystem$create to accept a path to json_credentials #34421
Comments
take |
paleolimbot
pushed a commit
that referenced
this issue
Mar 22, 2023
) ### Rationale for this change Existing documentation for this argument was misleading. ### What changes are included in this PR? A change in functionality, matching tests, and updated documentation are included. `json_credentials` can now either be a literal string containing credentials or a string containing a path to credentials. In the latter case, credentials will be automatically read in from the fileystem. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, though not breaking. This affects user-facing APIs and documentation and is both a bug fix and new functionality. Closes #34421 Closes #33106 * Closes: #34421 Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
Mar 27, 2023
apache#34524) ### Rationale for this change Existing documentation for this argument was misleading. ### What changes are included in this PR? A change in functionality, matching tests, and updated documentation are included. `json_credentials` can now either be a literal string containing credentials or a string containing a path to credentials. In the latter case, credentials will be automatically read in from the fileystem. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, though not breaking. This affects user-facing APIs and documentation and is both a bug fix and new functionality. Closes apache#34421 Closes apache#33106 * Closes: apache#34421 Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
apache#34524) ### Rationale for this change Existing documentation for this argument was misleading. ### What changes are included in this PR? A change in functionality, matching tests, and updated documentation are included. `json_credentials` can now either be a literal string containing credentials or a string containing a path to credentials. In the latter case, credentials will be automatically read in from the fileystem. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, though not breaking. This affects user-facing APIs and documentation and is both a bug fix and new functionality. Closes apache#34421 Closes apache#33106 * Closes: apache#34421 Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
As discovered in #33106,
GcsFileSystem$create
is documented to say it takes a path to a set of JSON credentials on disk. Right now, it only takes a character vector containing the JSON credentials.So this works:
And this does not:
I think both use cases should work so I think we should:
Component(s)
R
The text was updated successfully, but these errors were encountered: