Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][FlightRPC] Flight SQL client does not drain DoAction streams #34472

Closed
lidavidm opened this issue Mar 6, 2023 · 0 comments · Fixed by #34473
Closed

[Go][FlightRPC] Flight SQL client does not drain DoAction streams #34472

lidavidm opened this issue Mar 6, 2023 · 0 comments · Fixed by #34473
Assignees
@lidavidm
Labels
Component: FlightRPC Component: Go Type: bug
Milestone
12.0.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Mar 6, 2023

Describe the bug, including details regarding any error messages, version, and platform.

This is similar to a bug that was in the C++ Flight SQL client. This means that certain operations won't actually complete when the function returns, causing nondeterministic behavior in callers.

Component(s)

Go
@lidavidm lidavidm self-assigned this Mar 6, 2023
@lidavidm lidavidm changed the title [Go] Flight SQL client does not drain DoAction streams [Go][FlightRPC] Flight SQL client does not drain DoAction streams Mar 6, 2023
@github-actions github-actions bot mentioned this issue Mar 6, 2023
Merged
@lidavidm lidavidm mentioned this issue Mar 6, 2023
Closed
lidavidm added a commit that referenced this issue Mar 7, 2023
@lidavidm
GH-34472: [Go][FlightRPC] Drain result of DoAction in Flight SQL clie…
6fdf1e5 
…nt (#34473)

### Rationale for this change

Unless we drain the result of DoAction, we can't be sure that the RPC actually completed.

### What changes are included in this PR?

Always drain the result of DoAction.

### Are these changes tested?

A new test was added and existing tests were modified.

### Are there any user-facing changes?

This fixes potential nondeterministic behavior that users may have previously observed.
* Closes: #34472

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 12.0.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: FlightRPC Component: Go Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34472: [Go][FlightRPC] Drain result of DoAction in Flight SQL client lidavidm/arrow
1 participant
@lidavidm