[JS] Remove bin/bin directory from bundles

[domoritz]

Describe the bug, including details regarding any error messages, version, and platform.

The generated bundles contain a /bin/bin directory that should not be there.

Component(s)

JavaScript

[abetomo]

I haven't looked into it in detail, but the following patch may improve it.

--- a/js/gulp/typescript-task.js
+++ b/js/gulp/typescript-task.js
@@ -34,7 +34,6 @@ export const typescriptTask = ((cache) => memoizeTask(cache, function typescript
     const out = targetDir(target, format);
     const tsconfigPath = path.join(`tsconfig`, `tsconfig.${tsconfigName(target, format)}.json`);
     return compileTypescript(out, tsconfigPath)
-        .pipe(mergeWith(compileBinFiles(target, format)))
         .pipe(takeLast(1))
         .pipe(share({ connector: () => new ReplaySubject(), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }))
 }))({});

[domoritz]

We will need to check carefully since we want the bin files themselves included.

[abetomo]

Is it a problem you need solved in a hurry?
May I work on it?

[domoritz]

No rush. Go for it! It should be easy to see whether you succeeded by checking the bundles generated by npm pack. Thanks!

[abetomo]

Thanks for the reply!
I got it.

[abetomo]

take

[abetomo]

Is it correct that the following files generated under targets should not exist?

targets/apache-arrow/bin/bin/arrow2csv.js
targets/apache-arrow/bin/bin/arrow2csv.js.map
targets/apache-arrow/bin/bin/arrow2csv.mjs
targets/apache-arrow/bin/src/bin/arrow2csv.ts
targets/es2015/cjs/bin/bin/arrow2csv.js
targets/es2015/cjs/bin/bin/arrow2csv.js.map
targets/es2015/cjs/bin/src/bin/arrow2csv.ts
targets/es2015/esm/bin/bin/arrow2csv.js
targets/es2015/esm/bin/bin/arrow2csv.js.map
targets/es2015/esm/bin/src/bin/arrow2csv.ts
targets/es2015/umd/bin/bin/arrow2csv.js
targets/es2015/umd/bin/bin/arrow2csv.js.map
targets/es2015/umd/bin/src/bin/arrow2csv.ts
targets/es5/cjs/bin/bin/arrow2csv.js
targets/es5/cjs/bin/bin/arrow2csv.js.map
targets/es5/cjs/bin/src/bin/arrow2csv.ts
targets/es5/esm/bin/bin/arrow2csv.js
targets/es5/esm/bin/bin/arrow2csv.js.map
targets/es5/esm/bin/src/bin/arrow2csv.ts
targets/es5/umd/bin/bin/arrow2csv.js
targets/es5/umd/bin/bin/arrow2csv.js.map
targets/es5/umd/bin/src/bin/arrow2csv.ts
targets/esnext/cjs/bin/bin/arrow2csv.js
targets/esnext/cjs/bin/bin/arrow2csv.js.map
targets/esnext/cjs/bin/src/bin/arrow2csv.ts
targets/esnext/esm/bin/bin/arrow2csv.js
targets/esnext/esm/bin/bin/arrow2csv.js.map
targets/esnext/esm/bin/src/bin/arrow2csv.ts
targets/esnext/umd/bin/bin/arrow2csv.js
targets/esnext/umd/bin/bin/arrow2csv.js.map
targets/esnext/umd/bin/src/bin/arrow2csv.ts

[domoritz]

I think so, yes. We should make sure the scripts still work and that the sources are still in a location where the editor can give you correct sources.

[abetomo]

5598d2f#diff-cef18da59d581d0c92a1e262b6e7de2afac26d08cfa38fd8917f12fa9c48960fL2-R2

js/tsconfig/tsconfig.base.json

-  "exclude": ["../node_modules", "../src/bin/*.ts"],
+  "exclude": ["../node_modules"],

This change seems to generate bin without compileBinFiles(#34567 (comment)).