Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Update vendored double-conversion to 3.2.1 #34918

Closed
liujiacheng777 opened this issue Apr 6, 2023 · 0 comments · Fixed by #34919
Closed

[C++] Update vendored double-conversion to 3.2.1 #34918

liujiacheng777 opened this issue Apr 6, 2023 · 0 comments · Fixed by #34919

Comments

@liujiacheng777
Copy link
Contributor

liujiacheng777 commented Apr 6, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The current bundled double-conversion can't be built on LoongArch:

-- Configuring incomplete, errors occurred!
See also "/home/loongson/tmp/aa/arrow/cpp/build/CMakeFiles/CMakeOutput.log".

loongson@loongson-pc:~/tmp/arrow/cpp/build$ make
In file included from /home/loongson/tmp/aa/arrow/cpp/src/arrow/vendored/double-conversion/double-conversion.h:31,
                 from /home/loongson/tmp/aa/arrow/cpp/src/arrow/util/double_conversion.h:20,
                 from /home/loongson/tmp/aa/arrow/cpp/src/arrow/util/formatting.h:35,
                 from /home/loongson/tmp/aa/arrow/cpp/src/arrow/pretty_print.cc:41:
/home/loongson/tmp/aa/arrow/cpp/src/arrow/vendored/double-conversion/utils.h:118:2: error: #error Target architecture was not detected as supported by Double-Conversion.
 #error Target architecture was not detected as supported by Double-Conversion.
  ^~~~~
make[2]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/build.make:466:src/arrow/CMakeFiles/arrow_objlib.dir/pretty_print.cc.o] 错误 1
make[1]: *** [CMakeFiles/Makefile2:684:src/arrow/CMakeFiles/arrow_objlib.dir/all] 错误 2
make: *** [Makefile:141:all] 错误 2

Component(s)

C++

kou pushed a commit that referenced this issue May 19, 2023
Modifications based on doubleConversion version 3.2.1
* Closes: #34918

Authored-by: liujiacheng777 <liujiacheng@loongson.cn>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone May 19, 2023
@kou kou changed the title [C++] Update vendored double-conversion [C++] Update vendored double-conversion to 3.2.1 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants