Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Require CMake 3.16 or later #34921

Closed
kou opened this issue Apr 6, 2023 · 4 comments · Fixed by #35921
Closed

[C++] Require CMake 3.16 or later #34921

kou opened this issue Apr 6, 2023 · 4 comments · Fixed by #35921
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented Apr 6, 2023

Describe the enhancement requested

We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake 3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.

Component(s)

C++
@infdahai infdahai mentioned this issue Apr 7, 2023
Merged
kou added a commit that referenced this issue Apr 7, 2023
@infdahai @kou
GH-34945: [C++][Docs] Add missing cmake_minimum_required() to example (…
f4446c0 
…#34969)

1. add cmake_minimum_required(3.16) .
2. the version is based on #34921.

* Closes: #34945

Lead-authored-by: cluster <clusternlh@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@westonpace
Copy link
Member

I agree. Is there a change needed here or can this be closed now that #34969 has merged?

@kou
Copy link
Member Author

kou commented Apr 11, 2023

We can't close this yet because #34969 is just for an example project.

This issue is for cpp/CMakeLists.txt not an example project.

@kou kou mentioned this issue Apr 18, 2023
Open
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@infdahai @kou @liujiacheng777
apacheGH-34945: [C++][Docs] Add missing cmake_minimum_required() to e…
248e0d6 
…xample (apache#34969)

1. add cmake_minimum_required(3.16) .
2. the version is based on apache#34921.

* Closes: apache#34945

Lead-authored-by: cluster <clusternlh@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@infdahai @kou @ArgusLi
apacheGH-34945: [C++][Docs] Add missing cmake_minimum_required() to e…
bf2e296 
…xample (apache#34969)

1. add cmake_minimum_required(3.16) .
2. the version is based on apache#34921.

* Closes: apache#34945

Lead-authored-by: cluster <clusternlh@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@infdahai @kou @rtpsw
apacheGH-34945: [C++][Docs] Add missing cmake_minimum_required() to e…
d10ee6a 
…xample (apache#34969)

1. add cmake_minimum_required(3.16) .
2. the version is based on apache#34921.

* Closes: apache#34945

Lead-authored-by: cluster <clusternlh@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member Author

kou commented Jun 6, 2023

Debian GNU/Linux buster reached EOL on 2022-09-10:

https://wiki.debian.org/DebianReleases

Version Code name Release date End of life date EOL LTS EOL ELTS
10 Buster 2019-07-06 2022-09-10 2024-06-30

kou added a commit to kou/arrow that referenced this issue Jun 6, 2023
@kou
apacheGH-34921: [C++][Python][Java] Require CMake 3.16 or later
b9911f9 
We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake
3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports
repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.
@github-actions github-actions bot mentioned this issue Jun 6, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Jun 6, 2023
@kou
apacheGH-34921: [C++][Python][Java] Require CMake 3.16 or later
5d8bbea 
We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake
3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports
repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.
kou added a commit to kou/arrow that referenced this issue Jun 9, 2023
@kou
apacheGH-34921: [C++][Python][Java] Require CMake 3.16 or later
f7e97ce 
We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake
3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports
repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.
@kou
Copy link
Member Author

kou commented Jun 9, 2023

Oh... Amazon Linux 2 uses CMake 3.13.1...

kou added a commit to kou/arrow that referenced this issue Jun 10, 2023
@kou
apacheGH-34921: [C++][Python][Java] Require CMake 3.16 or later
43ab1ef 
We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake
3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports
repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.
@kou kou mentioned this issue Jun 22, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Jun 25, 2023
@kou
apacheGH-36241: [Packaging] Drop support for Amazon Linux 2
44a2e88 
We want to require CMake 3.16 or later. (apacheGH-34921)
If we drop support for Amazon Linux 2, we can require CMake 3.16 or later.
@kou kou mentioned this issue Jun 25, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Jun 25, 2023
@kou
apacheGH-36241: [Packaging] Drop support for Amazon Linux 2
77bd36e 
We want to require CMake 3.16 or later. (apacheGH-34921)
If we drop support for Amazon Linux 2, we can require CMake 3.16 or later.
kou added a commit that referenced this issue Jun 26, 2023
@kou
GH-36241: [Packaging] Drop support for Amazon Linux 2 (#36282)
781907a 
### Rationale for this change

We want to require CMake 3.16 or later. (GH-34921)
If we drop support for Amazon Linux 2, we can require CMake 3.16 or later.

### What changes are included in this PR?

Remove Amazon Linux 2 related codes.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #36241

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou added a commit to kou/arrow that referenced this issue Jun 26, 2023
@kou
apacheGH-34921: [C++][Python][Java] Require CMake 3.16 or later
a27528a 
We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake
3.17) or later, and Debian GNU/Linux buster (CMake 3.13 but backports
repository has CMake 3.18) or later.

So we can require CMake 3.16 or later.
kou added a commit that referenced this issue Jun 27, 2023
@kou
GH-34921: [C++][Python][Java] Require CMake 3.16 or later (#35921)
11b140a 
### Rationale for this change

We need to support Ubuntu 20.04 (CMake 3.16) or later, CentOS 7 (CMake 3.17) or later, and Debian GNU/Linux bullseye (CMake 3.18) or later.

So we can require CMake 3.16 or later.

### What changes are included in this PR?

Require CMake 3.16 or later.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #34921

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 27, 2023
@raulcd raulcd mentioned this issue Aug 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-34921: [C++][Python][Java] Require CMake 3.16 or later kou/arrow
2 participants
@kou @westonpace