-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] Table.slice
uses :emit_null
not :drop
for FilterOptions
#34953
Comments
kou
pushed a commit
that referenced
this issue
Apr 10, 2023
…:drop` (#34954) ### Rationale for this change `Table.slice` behaves as `FilterOptions.null_selection_behavior = :emit_null` for backward compatibility. But this is a differnt behavior from `Table#filter` and `Slicer::ColumnCondition#select` which use default option `:drop`. This request will change the behavior of `Table#slice` to align with the default of `FilterOptions`. ### What changes are included in this PR? Set `FilterOptions.null_selection_behavior` to the default value `:drop` from `:emit_null` . ### Are these changes tested? Yes. Rebased after #34952. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * Closes: #34953 Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Thhanks! |
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…` to `:drop` (apache#34954) ### Rationale for this change `Table.slice` behaves as `FilterOptions.null_selection_behavior = :emit_null` for backward compatibility. But this is a differnt behavior from `Table#filter` and `Slicer::ColumnCondition#select` which use default option `:drop`. This request will change the behavior of `Table#slice` to align with the default of `FilterOptions`. ### What changes are included in this PR? Set `FilterOptions.null_selection_behavior` to the default value `:drop` from `:emit_null` . ### Are these changes tested? Yes. Rebased after apache#34952. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * Closes: apache#34953 Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…` to `:drop` (apache#34954) ### Rationale for this change `Table.slice` behaves as `FilterOptions.null_selection_behavior = :emit_null` for backward compatibility. But this is a differnt behavior from `Table#filter` and `Slicer::ColumnCondition#select` which use default option `:drop`. This request will change the behavior of `Table#slice` to align with the default of `FilterOptions`. ### What changes are included in this PR? Set `FilterOptions.null_selection_behavior` to the default value `:drop` from `:emit_null` . ### Are these changes tested? Yes. Rebased after apache#34952. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * Closes: apache#34953 Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…` to `:drop` (apache#34954) ### Rationale for this change `Table.slice` behaves as `FilterOptions.null_selection_behavior = :emit_null` for backward compatibility. But this is a differnt behavior from `Table#filter` and `Slicer::ColumnCondition#select` which use default option `:drop`. This request will change the behavior of `Table#slice` to align with the default of `FilterOptions`. ### What changes are included in this PR? Set `FilterOptions.null_selection_behavior` to the default value `:drop` from `:emit_null` . ### Are these changes tested? Yes. Rebased after apache#34952. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * Closes: apache#34953 Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Table.slice
behaves asFilterOptions.null_selection_behavior = :emit_null
for backward compatibility.This is a differnt behavior from
Table#filter
andSlicer::ColumnCondition#select
which use default option
:drop
.Is it better to align with default option
:drop
forTable.slice
?Example:
This case:
Reference 1:
Reference 2:
Component(s)
Ruby
The text was updated successfully, but these errors were encountered: