Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Remove RelationInfo #35004

Closed
rtpsw opened this issue Apr 10, 2023 · 2 comments · Fixed by #35005
Closed

[C++] Remove RelationInfo #35004

rtpsw opened this issue Apr 10, 2023 · 2 comments · Fixed by #35005
Assignees
@rtpsw
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented Apr 10, 2023 •
edited by icexelloss

Describe the enhancement requested

Currently, there is a RelationInfo class in Acero whose purpose beyond that of DeclarationInfo is to specify the translation of an output mapping from input indices to output indices. However, Substrait column selection and emit documentation says the output mapping is already specified in terms of output indices.

Component(s)

C++
rtpsw added a commit to rtpsw/arrow that referenced this issue Apr 10, 2023
@rtpsw
apacheGH-35004: [C++] Remove output mapping translation
390824a
@rtpsw rtpsw mentioned this issue Apr 10, 2023
Merged
@icexelloss icexelloss changed the title [C++] Remove output mapping translation [C++] Remove Relation Info Apr 10, 2023
@icexelloss icexelloss changed the title [C++] Remove Relation Info [C++] Remove RelationInfo Apr 10, 2023
@wjones127
Copy link
Member

If I recall correctly, earlier this was necessary because the as-of join implementation deduplicates columns between the join inputs, while Substrait generally expects the output to just be a concatenation of the columns. Do you still think you can remove this while handling as-of join correctly?

@wjones127
Copy link
Member

cc @westonpace

rtpsw added a commit to rtpsw/arrow that referenced this issue Apr 14, 2023
@rtpsw
Merge branch 'main' into apacheGH-35004
e431b8a
@icexelloss icexelloss added this to the 13.0.0 milestone Apr 20, 2023
icexelloss pushed a commit that referenced this issue Apr 20, 2023
@rtpsw
GH-35004: [C++] Remove RelationInfo (#35005)
d5866ec 
See #35004
* Closes: #35004

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@rtpsw @liujiacheng777
apacheGH-35004: [C++] Remove RelationInfo (apache#35005)
6f47961 
See apache#35004
* Closes: apache#35004

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@rtpsw @ArgusLi
apacheGH-35004: [C++] Remove RelationInfo (apache#35005)
3f89fa5 
See apache#35004
* Closes: apache#35004

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
rtpsw added a commit to rtpsw/arrow that referenced this issue May 16, 2023
@rtpsw
apacheGH-35004: [C++] Remove RelationInfo (apache#35005)
4ac327f 
See apache#35004
* Closes: apache#35004

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35004: [C++] Remove RelationInfo rtpsw/arrow
3 participants
@icexelloss @wjones127 @rtpsw