Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] hash_count kernel miscounts when run-end encoded array contains null #35059

Closed
Tracked by #35207
felipecrv opened this issue Apr 12, 2023 · 0 comments · Fixed by #35129
Closed
Tracked by #35207

[C++] hash_count kernel miscounts when run-end encoded array contains null #35059

felipecrv opened this issue Apr 12, 2023 · 0 comments · Fixed by #35129
Assignees
Labels
Component: C++ Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Milestone

Comments

@felipecrv
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Passing run-end encoded array in unit tests leads to these failures:

[ RUN      ] GroupBy/GroupBy.CountOnly/0
/home/felipeo/code/arrow/cpp/src/arrow/testing/gtest_util.cc:100: Failure
Failed

@@ -0, +0 @@
-{key_0: 1, hash_count: 2}
+{key_0: 1, hash_count: 3}
@@ -2, +2 @@
-{key_0: 3, hash_count: 0}
+{key_0: 3, hash_count: 2}
Expected:
  -- is_valid: all not null
  -- child 0 type: int64
    [
      1,
      2,
      3,
      null
    ]
  -- child 1 type: int64
    [
      2,
      3,
      0,
      2
    ]
Actual:
  -- is_valid: all not null
  -- child 0 type: int64
    [
      1,
      2,
      3,
      null
    ]
  -- child 1 type: int64
    [
      3,
      3,
      2,
      2
    ]
    ```

### Component(s)

C++
westonpace pushed a commit that referenced this issue May 1, 2023
### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: #35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 13.0.0 milestone May 1, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
…ache#35129)

### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: apache#35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…ache#35129)

### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: apache#35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
…ache#35129)

### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: apache#35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@raulcd raulcd added the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: C++ Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants