Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Minimal build is failing (acero symbol not defined) #35073

Closed
paleolimbot opened this issue Apr 12, 2023 · 2 comments · Fixed by #35074
Closed

[R] Minimal build is failing (acero symbol not defined) #35073

paleolimbot opened this issue Apr 12, 2023 · 2 comments · Fixed by #35074
Assignees
@thisisnic
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone
12.0.0

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=47162&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=1292

g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-11.0.0.9000/include -DARROW_STATIC   -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -ffile-prefix-map=/build/r-base-4.2.3=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -c arrowExports.cpp -o arrowExports.o
arrowExports.cpp:1053:57: error: ‘acero’ was not declared in this scope
 1053 | bool ExecNode_has_ordered_batches(const std::shared_ptr<acero::ExecNode>& node);
      |                                                         ^~~~~
arrowExports.cpp:1053:72: error: template argument 1 is invalid
 1053 | bool ExecNode_has_ordered_batches(const std::shared_ptr<acero::ExecNode>& node);

Maybe related to #34685 merging?

Component(s)

R
@raulcd
Copy link
Member

raulcd commented Apr 12, 2023

@paleolimbot should this be marked as a blocker?

@thisisnic thisisnic self-assigned this Apr 12, 2023
@thisisnic
Copy link
Member

I think so. And I think I've spotted the cause, will get a PR up ASAP

@raulcd raulcd added this to the 12.0.0 milestone Apr 12, 2023
@raulcd raulcd added the Priority: Blocker Marks a blocker for the release label Apr 12, 2023
@github-actions github-actions bot mentioned this issue Apr 12, 2023
Merged
assignUser pushed a commit that referenced this issue Apr 12, 2023
@thisisnic
GH-35073: [R] Minimal build is failing (acero symbol not defined) (#3…
c4312ea 
…5074)

This PR updates the decorator in a function introduced in #34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: #35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@thisisnic @liujiacheng777
apacheGH-35073: [R] Minimal build is failing (acero symbol not define…
60534c6 
…d) (apache#35074)

This PR updates the decorator in a function introduced in apache#34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: apache#35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@thisisnic @ArgusLi
apacheGH-35073: [R] Minimal build is failing (acero symbol not define…
a8f71a4 
…d) (apache#35074)

This PR updates the decorator in a function introduced in apache#34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: apache#35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@thisisnic @rtpsw
apacheGH-35073: [R] Minimal build is failing (acero symbol not define…
5431cb3 
…d) (apache#35074)

This PR updates the decorator in a function introduced in apache#34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: apache#35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-35073: [R] Minimal build is failing (acero symbol not defined) thisisnic/arrow
3 participants
@raulcd @paleolimbot @thisisnic