Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][FlightSQL] Allow non-prepared queries #35136

Closed
srebhan opened this issue Apr 14, 2023 · 0 comments · Fixed by #35137
Closed

[Go][FlightSQL] Allow non-prepared queries #35136

srebhan opened this issue Apr 14, 2023 · 0 comments · Fixed by #35137
Assignees
@srebhan
Labels
Component: FlightRPC Component: Go Type: enhancement
Milestone
13.0.0

Comments

@srebhan
Copy link
Contributor

srebhan commented Apr 14, 2023

Describe the enhancement requested

Currently, all queries are prepared as the driver does not implement the QueryerContext interface. As a consequence all backends not supporting CreatePreparedStatement will fail and cannot be used with the driver.

Please implement QueryerContext to allow usage of the mentioned backends with the driver.

Component(s)

FlightRPC, Go
@github-actions github-actions bot mentioned this issue Apr 14, 2023
Merged
zeroshade pushed a commit that referenced this issue Apr 14, 2023
@srebhan
GH-35136: [Go][FlightSQL] Support backends without `CreatePreparedSta…
bb69b9f 
…tement` implemented (#35137)

Without this PR all backends that do not implement `CreatePreparedStatement` will error out as the `database/sql` framework tries to prepare/execute all queries if the `QueryerContext` is missing. See linked issue.
* Closes: #35136

Authored-by: Sven Rebhan <srebhan@influxdata.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Apr 14, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@srebhan @liujiacheng777
apacheGH-35136: [Go][FlightSQL] Support backends without `CreatePrepa…
e83b272 
…redStatement` implemented (apache#35137)

Without this PR all backends that do not implement `CreatePreparedStatement` will error out as the `database/sql` framework tries to prepare/execute all queries if the `QueryerContext` is missing. See linked issue.
* Closes: apache#35136

Authored-by: Sven Rebhan <srebhan@influxdata.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@srebhan @ArgusLi
apacheGH-35136: [Go][FlightSQL] Support backends without `CreatePrepa…
59ab1ba 
…redStatement` implemented (apache#35137)

Without this PR all backends that do not implement `CreatePreparedStatement` will error out as the `database/sql` framework tries to prepare/execute all queries if the `QueryerContext` is missing. See linked issue.
* Closes: apache#35136

Authored-by: Sven Rebhan <srebhan@influxdata.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@srebhan @rtpsw
apacheGH-35136: [Go][FlightSQL] Support backends without `CreatePrepa…
3307bec 
…redStatement` implemented (apache#35137)

Without this PR all backends that do not implement `CreatePreparedStatement` will error out as the `database/sql` framework tries to prepare/execute all queries if the `QueryerContext` is missing. See linked issue.
* Closes: apache#35136

Authored-by: Sven Rebhan <srebhan@influxdata.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srebhan srebhan

Labels
Component: FlightRPC Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35136: [Go][FlightSQL] Support backends without CreatePreparedStatement implemented srebhan/arrow
2 participants
@zeroshade @srebhan