[C++] Unit test regression introduced by #34931 #35144
Comments
westonpace
added a commit
that referenced
this issue
Apr 14, 2023
…ggregate node changed (#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: #35144 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
#34931 changed the order of of the aggregate node. There was one unit test that was not updated with the new order and is now failing. The new unit test was introduced recently in #34904 so I think the PR for #34931 probably wasn't rebased in the last day or two and so missed the check.
Component(s)
C++
The text was updated successfully, but these errors were encountered: