Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] CSV Reader fails to read empty values as null #35190

Closed
hermanschaaf opened this issue Apr 17, 2023 · 0 comments · Fixed by #35191
Closed

[Go] CSV Reader fails to read empty values as null #35190

hermanschaaf opened this issue Apr 17, 2023 · 0 comments · Fixed by #35191
Assignees
@hermanschaaf
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@hermanschaaf
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

When the CSV reader is passed empty string as one of the possible null values, it still returns this as an empty string rather than null, even when used with the WithNullReader(stringsCanBeNull=true) option.

Component(s)

Go
@github-actions github-actions bot mentioned this issue Apr 17, 2023
Merged
zeroshade pushed a commit that referenced this issue Apr 18, 2023
@hermanschaaf
GH-35190: [Go] Correctly handle null values in CSV reader (#35191)
16bd95f 
The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this.
* Closes: #35190

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Apr 18, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@hermanschaaf @liujiacheng777
apacheGH-35190: [Go] Correctly handle null values in CSV reader (apac…
7ab6ac5 
…he#35191)

The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this.
* Closes: apache#35190

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@hermanschaaf @ArgusLi
apacheGH-35190: [Go] Correctly handle null values in CSV reader (apac…
ad541bb 
…he#35191)

The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this.
* Closes: apache#35190

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@hermanschaaf @rtpsw
apacheGH-35190: [Go] Correctly handle null values in CSV reader (apac…
17e0a8d 
…he#35191)

The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this.
* Closes: apache#35190

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermanschaaf hermanschaaf

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35190: [Go] Correctly handle null values in CSV reader cloudquery/arrow
2 participants
@zeroshade @hermanschaaf