Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Add explicit test for passing of name to pandas_api.series in ChunkedArray #35250

Closed
AlenkaF opened this issue Apr 20, 2023 · 0 comments · Fixed by #35546
Closed

[Python] Add explicit test for passing of name to pandas_api.series in ChunkedArray #35250

AlenkaF opened this issue Apr 20, 2023 · 0 comments · Fixed by #35546
Assignees
@AlenkaF
Labels
Component: Python Type: enhancement
Milestone
13.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Apr 20, 2023

Describe the enhancement requested

This is a follow up to #35248 which fixed failing tests for new versions of pandas. We should add explicit tests for passing of name to pandas_api.series in ChunkedArray.

See: https://github.com/apache/arrow/pull/35248/files#r1172412311

Component(s)

Python
@AlenkaF AlenkaF mentioned this issue Apr 20, 2023
Merged
@AlenkaF AlenkaF self-assigned this Apr 20, 2023
@github-actions github-actions bot mentioned this issue May 11, 2023
Merged
jorisvandenbossche pushed a commit that referenced this issue Jun 1, 2023
@AlenkaF
GH-35250: [Python] Add test for datetime column conversion to pandas (#…
3456131 
…35546)

### Rationale for this change
In pandas version 2.1.0 `__from_arrow__` method has been implemented for `DatetimeTZDtype` extension type. See pandas-dev/pandas#52201.

Due to this change, the conversion from pyarrow table column with datetime uses the newly implemented `__from_arrow__` method for the pandas dtype and `pandas_api.series` to construct the pandas series. We had to pass the name in the `pandas_api.series` also, to fix failing tests in #35248.

This PR adds explicit test for this change.
* Closes: #35250

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35250: [Python] Add test for datetime column conversion to pandas AlenkaF/arrow
2 participants
@jorisvandenbossche @AlenkaF