Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] auto enable brotli when enable ARROW_FUZZING #35282

Closed
mapleFU opened this issue Apr 22, 2023 · 0 comments · Fixed by #35283
Closed

[C++] auto enable brotli when enable ARROW_FUZZING #35282

mapleFU opened this issue Apr 22, 2023 · 0 comments · Fixed by #35283
Assignees
@mapleFU
Labels
Component: C++ Component: Developer Tools Type: enhancement
Milestone
13.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Apr 22, 2023

Describe the enhancement requested

In parquet/arrow/generate_fuzz_corpus.cc, it depends on brotli. However, arrow didn't auto enable it:

std::shared_ptr<WriterProperties> GetWriterProperties() {
  WriterProperties::Builder builder{};
  builder.disable_dictionary("no_dict");
  builder.compression("compressed", Compression::BROTLI);
  return builder.build();
}

Component(s)

C++, Developer Tools
@github-actions github-actions bot mentioned this issue Apr 22, 2023
Merged
kou pushed a commit that referenced this issue Apr 26, 2023
@mapleFU
GH-35282: [C++] auto enable brotli when enable fuzzing (#35283)
8fbf2d7 
### Rationale for this change

Auto enable brotli when enable fuzzing

### What changes are included in this PR?

Detect Fuzzing enabled, if it's, enable BROTLI

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #35282

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Apr 26, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@mapleFU @liujiacheng777
apacheGH-35282: [C++] auto enable brotli when enable fuzzing (apache#…
a9ba089 
…35283)

### Rationale for this change

Auto enable brotli when enable fuzzing

### What changes are included in this PR?

Detect Fuzzing enabled, if it's, enable BROTLI

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35282

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@mapleFU @ArgusLi
apacheGH-35282: [C++] auto enable brotli when enable fuzzing (apache#…
ea75af5 
…35283)

### Rationale for this change

Auto enable brotli when enable fuzzing

### What changes are included in this PR?

Detect Fuzzing enabled, if it's, enable BROTLI

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35282

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@mapleFU @rtpsw
apacheGH-35282: [C++] auto enable brotli when enable fuzzing (apache#…
252bc0f 
…35283)

### Rationale for this change

Auto enable brotli when enable fuzzing

### What changes are included in this PR?

Detect Fuzzing enabled, if it's, enable BROTLI

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35282

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35282: [C++] auto enable brotli when enable fuzzing mapleFU/arrow
2 participants
@kou @mapleFU