Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Lists ValueOffsets implementation seems to be buggy #35326

Closed
candiduslynx opened this issue Apr 25, 2023 · 0 comments · Fixed by #35327
Closed

[Go] Lists ValueOffsets implementation seems to be buggy #35326

candiduslynx opened this issue Apr 25, 2023 · 0 comments · Fixed by #35327
Assignees
@candiduslynx
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@candiduslynx
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Currently the *array.List and *array.LargeList use an internal function to calculate value offsets accounting for a.array.data.offset.
The ValueOffsets implementations of those don't do that.

Component(s)

Go
@github-actions github-actions bot mentioned this issue Apr 25, 2023
Merged
zeroshade pushed a commit that referenced this issue Apr 25, 2023
@candiduslynx
GH-35326: [Go] Fix *array.List and *array.LargeList `ValueOffsets…
28c6812 
…` implementation (#35327)

This fix also is connected to #35325 (as adds `*array.FixedSizeList` to the same bunch).

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #35326
* Closes: #35325

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Apr 25, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@candiduslynx @liujiacheng777
apacheGH-35326: [Go] Fix *array.List and *array.LargeList `ValueO…
a84b0dc 
…ffsets` implementation (apache#35327)

This fix also is connected to apache#35325 (as adds `*array.FixedSizeList` to the same bunch).

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35326
* Closes: apache#35325

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@candiduslynx @ArgusLi
apacheGH-35326: [Go] Fix *array.List and *array.LargeList `ValueO…
075305d 
…ffsets` implementation (apache#35327)

This fix also is connected to apache#35325 (as adds `*array.FixedSizeList` to the same bunch).

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35326
* Closes: apache#35325

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@candiduslynx @rtpsw
apacheGH-35326: [Go] Fix *array.List and *array.LargeList `ValueO…
cb9c613 
…ffsets` implementation (apache#35327)

This fix also is connected to apache#35325 (as adds `*array.FixedSizeList` to the same bunch).

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35326
* Closes: apache#35325

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@candiduslynx candiduslynx

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35326: [Go] Fix *array.List and *array.LargeList ValueOffsets implementation cloudquery/arrow
2 participants
@zeroshade @candiduslynx