Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Remove Perl dependency from cpp/build-support/run-test.sh #35361

Closed
kou opened this issue Apr 28, 2023 · 0 comments · Fixed by #35362
Closed

[C++] Remove Perl dependency from cpp/build-support/run-test.sh #35361

kou opened this issue Apr 28, 2023 · 0 comments · Fixed by #35362
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented Apr 28, 2023

Describe the enhancement requested

Perl may not be so portable as before

See also:

https://lists.apache.org/thread/ys0w82slp3d7w3ngprqnqjlwmzf5brqc

I have uploaded the log [1] for the run using conda with gandiva active. It
looks like there is an issue with libcrypt.so causing these tests to
segfault.

1: https://gist.github.com/assignUser/cba0a13875de9d6a4f31000f585244f0

https://lists.apache.org/thread/w47852gv4h9ngkjdnfhnmnqnx6km5nlb

libcrypto.so isn't related on the segmentation fault. It's
just for relating to showing backtrace.

perl: error while loading shared libraries: libcrypt.so.1:
cannot open shared object file: No such file or directory

This is happen at
https://github.com/apache/arrow/blob/main/cpp/build-support/run-test.sh#L42
:

TEST_NAME=$(echo $TEST_FILENAME | perl -pe 's/\..+?$//') # Remove path and extension (if any).

Component(s)

C++
kou added a commit to kou/arrow that referenced this issue Apr 28, 2023
@kou
apacheGH-35361: [C++] Remove Perl dependency from cpp/build-support/r…
68d5d93 
…un-test.sh

We can re-implement the addr2line filter in other language such as
Python or shell if we still need it.
@github-actions github-actions bot mentioned this issue Apr 28, 2023
Merged
@kou kou added this to the 13.0.0 milestone Apr 28, 2023
kou added a commit that referenced this issue Apr 28, 2023
@kou
GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-tes…
05a61d6 
…t.sh (#35362)

### Rationale for this change

Because Perl in conda doesn't work on Manjaro Linux.

### What changes are included in this PR?

* Use `sed` instead of `perl`.
* Remove `stacktrace_addr2line.pl`. If we still need it, we can re-implement the addr2line filter in other language such as Python or shell later.

### Are these changes tested?

Yes by hand on Manjaro Linux.

### Are there any user-facing changes?

No.
* Closes: #35361

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kou @liujiacheng777
apacheGH-35361: [C++] Remove Perl dependency from cpp/build-support/r…
2f87365 
…un-test.sh (apache#35362)

### Rationale for this change

Because Perl in conda doesn't work on Manjaro Linux.

### What changes are included in this PR?

* Use `sed` instead of `perl`.
* Remove `stacktrace_addr2line.pl`. If we still need it, we can re-implement the addr2line filter in other language such as Python or shell later.

### Are these changes tested?

Yes by hand on Manjaro Linux.

### Are there any user-facing changes?

No.
* Closes: apache#35361

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-35361: [C++] Remove Perl dependency from cpp/build-support/r…
ccc54d8 
…un-test.sh (apache#35362)

### Rationale for this change

Because Perl in conda doesn't work on Manjaro Linux.

### What changes are included in this PR?

* Use `sed` instead of `perl`.
* Remove `stacktrace_addr2line.pl`. If we still need it, we can re-implement the addr2line filter in other language such as Python or shell later.

### Are these changes tested?

Yes by hand on Manjaro Linux.

### Are there any user-facing changes?

No.
* Closes: apache#35361

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kou @rtpsw
apacheGH-35361: [C++] Remove Perl dependency from cpp/build-support/r…
a0b56e1 
…un-test.sh (apache#35362)

### Rationale for this change

Because Perl in conda doesn't work on Manjaro Linux.

### What changes are included in this PR?

* Use `sed` instead of `perl`.
* Remove `stacktrace_addr2line.pl`. If we still need it, we can re-implement the addr2line filter in other language such as Python or shell later.

### Are these changes tested?

Yes by hand on Manjaro Linux.

### Are there any user-facing changes?

No.
* Closes: apache#35361

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh kou/arrow
1 participant
@kou