Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FlightRPC] arrow-flight-test is crashed without ARROW_TEST_DATA #35379

Closed
kou opened this issue May 1, 2023 · 0 comments · Fixed by #35380
Closed

[C++][FlightRPC] arrow-flight-test is crashed without ARROW_TEST_DATA #35379

kou opened this issue May 1, 2023 · 0 comments · Fixed by #35380
Assignees
@kou
Labels
Component: C++ Component: FlightRPC Type: bug
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented May 1, 2023 •
edited

Describe the bug, including details regarding any error messages, version, and platform.

$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN      ] TestTls.DoAction
E0501 16:24:25.455014704  800882 ssl_security_connector.cc:270]        Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228  800882 chttp2_server.cc:1045]                UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
.../cpp/src/arrow/flight/test_util.cc:784  GetTestResourceRoot(&root)

Because

arrow/cpp/src/arrow/flight/flight_test.cc

Line 396 in 0ea1a10

ASSERT_OK(ExampleTlsCertificates(&options.tls_certificates));
is failed. client_ isn't created and server_->Init() isn't called when TearDown() is executed.

Component(s)

C++, FlightRPC
@kou kou added the Type: bug label May 1, 2023
@kou kou changed the title [C++][Flight] arrow-flight-test is crashed without ARROW_TEST_DATA [C++][FlightRPC] arrow-flight-test is crashed without ARROW_TEST_DATA May 1, 2023
kou added a commit to kou/arrow that referenced this issue May 1, 2023
@kou
apacheGH-35379: [C++][FlightRPC] Add teardown needed checks to avoid …
873ea1c 
…crash on error
@github-actions github-actions bot mentioned this issue May 1, 2023
Merged
@kou kou closed this as completed in #35380 May 1, 2023
kou added a commit that referenced this issue May 1, 2023
@kou
GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash …
41adf00 
…on error (#35380)

### Rationale for this change

If `ARROW_TEST_DATA` isn't set, `arrow-flight-test` is crashed:

```console
$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN      ] TestTls.DoAction
E0501 16:24:25.455014704  800882 ssl_security_connector.cc:270]        Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228  800882 chttp2_server.cc:1045]                UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
../cpp/src/arrow/flight/test_util.cc:784  GetTestResourceRoot(&root)
```

Because `client_` isn't created and `server_->Init()` isn't called when this error is occurred and `TearDown()` is executed.

### What changes are included in this PR?

Executes each teardown process only when they are needed.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #35379

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone May 1, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kou @liujiacheng777
apacheGH-35379: [C++][FlightRPC] Add teardown needed checks to avoid …
99019a4 
…crash on error (apache#35380)

### Rationale for this change

If `ARROW_TEST_DATA` isn't set, `arrow-flight-test` is crashed:

```console
$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN      ] TestTls.DoAction
E0501 16:24:25.455014704  800882 ssl_security_connector.cc:270]        Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228  800882 chttp2_server.cc:1045]                UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
../cpp/src/arrow/flight/test_util.cc:784  GetTestResourceRoot(&root)
```

Because `client_` isn't created and `server_->Init()` isn't called when this error is occurred and `TearDown()` is executed.

### What changes are included in this PR?

Executes each teardown process only when they are needed.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#35379

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-35379: [C++][FlightRPC] Add teardown needed checks to avoid …
6212de5 
…crash on error (apache#35380)

### Rationale for this change

If `ARROW_TEST_DATA` isn't set, `arrow-flight-test` is crashed:

```console
$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN      ] TestTls.DoAction
E0501 16:24:25.455014704  800882 ssl_security_connector.cc:270]        Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228  800882 chttp2_server.cc:1045]                UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
../cpp/src/arrow/flight/test_util.cc:784  GetTestResourceRoot(&root)
```

Because `client_` isn't created and `server_->Init()` isn't called when this error is occurred and `TearDown()` is executed.

### What changes are included in this PR?

Executes each teardown process only when they are needed.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#35379

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kou @rtpsw
apacheGH-35379: [C++][FlightRPC] Add teardown needed checks to avoid …
b7e0b63 
…crash on error (apache#35380)

### Rationale for this change

If `ARROW_TEST_DATA` isn't set, `arrow-flight-test` is crashed:

```console
$ LD_LIBRARY_PATH=$PWD/debug debug/arrow-flight-test
...
[----------] 4 tests from TestTls
[ RUN      ] TestTls.DoAction
E0501 16:24:25.455014704  800882 ssl_security_connector.cc:270]        Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E0501 16:24:25.455054228  800882 chttp2_server.cc:1045]                UNKNOWN:Unable to create secure server with credentials of type Ssl {file:"./src/core/ext/transport/chttp2/server/chttp2_server.cc", file_line:1032, created_time:"2023-05-01T16:24:25.455046974+09:00"}
/home/kou/work/cpp/arrow.kou/cpp/src/arrow/flight/flight_test.cc:396: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data
../cpp/src/arrow/flight/test_util.cc:784  GetTestResourceRoot(&root)
```

Because `client_` isn't created and `server_->Init()` isn't called when this error is occurred and `TearDown()` is executed.

### What changes are included in this PR?

Executes each teardown process only when they are needed.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#35379

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: FlightRPC Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35379: [C++][FlightRPC] Add teardown needed checks to avoid crash on error kou/arrow
1 participant
@kou