Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby][Flight] Add ArrowFlight::Client#authenticate_basic #35435

Closed
kou opened this issue May 4, 2023 · 0 comments · Fixed by #35436
Closed

[Ruby][Flight] Add ArrowFlight::Client#authenticate_basic #35435

kou opened this issue May 4, 2023 · 0 comments · Fixed by #35436

Comments

@kou
Copy link
Member

kou commented May 4, 2023

Describe the enhancement requested

It authenticates by #authenticate_basic_token and adds a Bearer authorization header to ArrowFlight::CallOptions.

Component(s)

FlightRPC, Ruby

kou added a commit to kou/arrow that referenced this issue May 4, 2023
@kou kou closed this as completed in #35436 May 5, 2023
@kou kou added this to the 13.0.0 milestone May 5, 2023
kou added a commit that referenced this issue May 5, 2023
…35436)

### Rationale for this change

`ArrowFlight::Client#authenticate_basic_token` is inconvenient because users need to set a returned Bearer token manually.

### What changes are included in this PR?

Adds a convenient method for a common Basic authentication use case.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #35435

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
…asic (apache#35436)

### Rationale for this change

`ArrowFlight::Client#authenticate_basic_token` is inconvenient because users need to set a returned Bearer token manually.

### What changes are included in this PR?

Adds a convenient method for a common Basic authentication use case.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35435

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…asic (apache#35436)

### Rationale for this change

`ArrowFlight::Client#authenticate_basic_token` is inconvenient because users need to set a returned Bearer token manually.

### What changes are included in this PR?

Adds a convenient method for a common Basic authentication use case.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35435

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
…asic (apache#35436)

### Rationale for this change

`ArrowFlight::Client#authenticate_basic_token` is inconvenient because users need to set a returned Bearer token manually.

### What changes are included in this PR?

Adds a convenient method for a common Basic authentication use case.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35435

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant