Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Fix Acero var/std for multiple batches #35468

Closed
rtpsw opened this issue May 6, 2023 · 0 comments · Fixed by #35469
Closed

[C++] Fix Acero var/std for multiple batches #35468

rtpsw opened this issue May 6, 2023 · 0 comments · Fixed by #35469
Assignees
@rtpsw
Labels
Component: C++ Type: bug
Milestone
13.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented May 6, 2023

Describe the bug, including details regarding any error messages, version, and platform.

In Acero, var/std computation resets the kernel state, instead of augmenting it, with each batch processed.

Component(s)

C++
@rtpsw rtpsw added the Type: bug label May 6, 2023
rtpsw added a commit to rtpsw/arrow that referenced this issue May 6, 2023
@rtpsw
apacheGH-35468: [C++] Fix Acero var/std for multiple batches
0b19cf3
@rtpsw rtpsw mentioned this issue May 6, 2023
Merged
westonpace pushed a commit that referenced this issue May 8, 2023
@rtpsw
GH-35468: [C++] Fix Acero var/std for multiple batches (#35469)
5b8eb64 
See #35468

**This PR contains a "Critical Fix".**

The current result of Acero var/std for multiple batches is incorrect.
* Closes: #35468

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 13.0.0 milestone May 8, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@rtpsw @liujiacheng777
apacheGH-35468: [C++] Fix Acero var/std for multiple batches (apache#…
eff04ca 
…35469)

See apache#35468

**This PR contains a "Critical Fix".**

The current result of Acero var/std for multiple batches is incorrect.
* Closes: apache#35468

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@rtpsw @ArgusLi
apacheGH-35468: [C++] Fix Acero var/std for multiple batches (apache#…
962b360 
…35469)

See apache#35468

**This PR contains a "Critical Fix".**

The current result of Acero var/std for multiple batches is incorrect.
* Closes: apache#35468

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw added a commit to rtpsw/arrow that referenced this issue May 16, 2023
@rtpsw
apacheGH-35468: [C++] Fix Acero var/std for multiple batches (apache#…
1f70ffd 
…35469)

See apache#35468

**This PR contains a "Critical Fix".**

The current result of Acero var/std for multiple batches is incorrect.
* Closes: apache#35468

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35468: [C++] Fix Acero var/std for multiple batches rtpsw/arrow
2 participants
@westonpace @rtpsw